Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: fix emitting duplicate implementors in .js files #33509

Merged
merged 1 commit into from
May 10, 2016
Merged

rustdoc: fix emitting duplicate implementors in .js files #33509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustdoc/html/render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ fn write_shared(cx: &Context,
try_err!(write!(&mut f, "{}", *implementor), &mydst);
}

try_err!(write!(&mut f, r"implementors['{}'] = [", krate.name), &mydst);
try_err!(write!(&mut f, r#"implementors["{}"] = ["#, krate.name), &mydst);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it wouldn't be better to just use escaped double quotes...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind. I was being consistent with https://github.com/birkenfeld/rust/blob/issue-30219/src/librustdoc/html/render.rs#L729

for imp in imps {
// If the trait and implementation are in the same crate, then
// there's no need to emit information about it (there's inlining
Expand Down