Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E0500 error explanation #33533

Merged
merged 1 commit into from
May 15, 2016
Merged

Add E0500 error explanation #33533

merged 1 commit into from
May 15, 2016

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 10, 2016 •
edited
Loading

r? @Manishearth

Part of #32777.

manfredbrandl
manfredbrandl reviewed May 10, 2016
View reviewed changes
src/librustc_borrowck/diagnostics.rs
let mut john_copy = john_snow.clone();
let nights_watch = || {
john_copy = 2;
};
Copy link

@manfredbrandl manfredbrandl May 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*john_copy = 2;
missing * ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I answered too quickly: there is no need for the Deref use here.

@GuillaumeGomez
Copy link
Member Author

cc @steveklabnik

steveklabnik
steveklabnik reviewed May 12, 2016
View reviewed changes
src/librustc_borrowck/diagnostics.rs
}
```

Or, if the type implements the `Clone` traits, you can clone it between
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trait, not traits

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2016

📌 Commit 7a9f4c2 has been approved by steveklabnik

@eddyb eddyb mentioned this pull request May 12, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request May 12, 2016
@eddyb
Rollup merge of rust-lang#33533 - GuillaumeGomez:add_E0500, r=stevekl…
7b2b98a 
…abnik

Add E0500 error explanation

r? @Manishearth

Part of rust-lang#32777.
@eddyb eddyb mentioned this pull request May 12, 2016
Closed
bors added a commit that referenced this pull request May 12, 2016
@bors
Auto merge of #33597 - eddyb:rollup, r=eddyb
2c5ce8c 
Rollup of 23 pull requests

- Successful merges: #33282, #33342, #33393, #33450, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33555, #33560, #33563, #33565, #33566, #33572, #33580, #33590, #33596
- Failed merges: #33578
@eddyb eddyb mentioned this pull request May 13, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request May 13, 2016
@eddyb
Rollup merge of rust-lang#33533 - GuillaumeGomez:add_E0500, r=stevekl…
e141d95 
…abnik

Add E0500 error explanation

r? @Manishearth

Part of rust-lang#32777.
sanxiyn added a commit to sanxiyn/rust that referenced this pull request May 14, 2016
@sanxiyn
Rollup merge of rust-lang#33533 - GuillaumeGomez:add_E0500, r=stevekl…
7de362a 
…abnik

Add E0500 error explanation

r? @Manishearth

Part of rust-lang#32777.
@sanxiyn sanxiyn mentioned this pull request May 14, 2016
Closed
bors added a commit that referenced this pull request May 14, 2016
@bors
Auto merge of #33629 - sanxiyn:rollup, r=sanxiyn
a9d15db 
Rollup of 15 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33590, #33591, #33598, #33603, #33604, #33605
- Failed merges: #33578
@eddyb eddyb mentioned this pull request May 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 15, 2016
@Manishearth
Rollup merge of rust-lang#33533 - GuillaumeGomez:add_E0500, r=stevekl…
0f4f51b 
…abnik

Add E0500 error explanation

r? @Manishearth

Part of rust-lang#32777.
@Manishearth Manishearth mentioned this pull request May 15, 2016
Merged
bors added a commit that referenced this pull request May 15, 2016
@bors
Auto merge of #33658 - Manishearth:rollup, r=Manishearth
9f58fb7 
Rollup of 14 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598
- Failed merges: #33578
@bors bors merged commit 7a9f4c2 into rust-lang:master May 15, 2016
@GuillaumeGomez GuillaumeGomez deleted the add_E0500 branch May 15, 2016 22:30
bors added a commit that referenced this pull request May 16, 2016
@bors
Auto merge of #33643 - eddyb:rollup, r=eddyb
bb39c49 
Rollup of 27 pull requests

- Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635
- Failed merges: #33578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @steveklabnik @bors @birkenfeld @manfredbrandl @Manishearth