Support references to outer type params for assoc consts #33572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const BOTTOM: Self; | ||
| } | ||
|
|
||
| impl<T: 'static> Lattice for Option<T> { |
There was a problem hiding this comment.
Maybe open an issue and add a FIXME here? We should support this.
|
r=me with the FIXME added |
|
@bors r=eddyb |
|
📌 Commit d3218fa has been approved by |
eddyb
added
the
beta-nominated
|
Nominated for beta because we might want to use this at stage0. |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 12, 2016
Support references to outer type params for assoc consts Fixes rust-lang#28809 r? @eddyb
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
May 13, 2016
Support references to outer type params for assoc consts Fixes rust-lang#28809 r? @eddyb
|
I ended up never using the features so there’s no need to backport to beta anymore. |
nagisa
removed
the
beta-nominated
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 14, 2016
Support references to outer type params for assoc consts Fixes rust-lang#28809 r? @eddyb
bors
added a commit
that referenced
this pull request
May 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28809
r? @eddyb