Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Debug for SplitWhitespace. #44303

Merged
merged 1 commit into from
Sep 7, 2017
Merged

impl Debug for SplitWhitespace. #44303

merged 1 commit into from
Sep 7, 2017

Conversation

clarfonthey
Copy link
Contributor

This one got missed because libstd_unicode doesn't have a deny(missing_debug_implementations) like libstd and libcore. I think that perhaps this lint should check for items exported from other crates too.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@clarfonthey clarfonthey mentioned this pull request Sep 3, 2017
Closed
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 5, 2017

📌 Commit 4260e43 has been approved by alexcrichton

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2017
@kennytm
Copy link
Member

kennytm commented Sep 5, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44303 - clarcharr:debugs, r=alexcrichton
3602c6f 
impl Debug for SplitWhitespace.

This one got missed because `libstd_unicode` doesn't have a `deny(missing_debug_implementations)` like `libstd` and `libcore`. I think that perhaps this lint should check for items exported from other crates too.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44303 - clarcharr:debugs, r=alexcrichton
923c351 
impl Debug for SplitWhitespace.

This one got missed because `libstd_unicode` doesn't have a `deny(missing_debug_implementations)` like `libstd` and `libcore`. I think that perhaps this lint should check for items exported from other crates too.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit 4260e43 into rust-lang:master Sep 7, 2017
@clarfonthey clarfonthey deleted the debugs branch October 8, 2017 22:56
@clarfonthey clarfonthey mentioned this pull request Apr 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clarfonthey @rust-highfive @alexcrichton @bors @kennytm @arielb1