Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest changing literals instead of calling methods (fixes #44307) #44361

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Suggest changing literals instead of calling methods (fixes #44307) #44361

merged 1 commit into from
Sep 7, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 6, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

travis failure appears spurious.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2017

📌 Commit ddd0145 has been approved by nikomatsakis

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44361 - oli-obk:lit_sugg, r=nikomatsakis
7232d12 
Suggest changing literals instead of calling methods (fixes rust-lang#44307)
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 6, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44361 - oli-obk:lit_sugg, r=nikomatsakis
f8b7c3e 
Suggest changing literals instead of calling methods (fixes rust-lang#44307)
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit ddd0145 into rust-lang:master Sep 7, 2017
@oli-obk oli-obk deleted the lit_sugg branch June 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @nikomatsakis @bors @Mark-Simulacrum @alexcrichton