Raw string error note #48546
Merged
Raw string error note #48546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
raw-string-error-note
branch
from
2135a57
to
b4ee47d
Compare
varkor
reviewed
Feb 26, 2018
src/test/ui/raw_string.rs
Outdated
| fn main() { | ||
| let x = r##"lol"#; | ||
| //~^ ERROR unterminated raw string | ||
| } |
There was a problem hiding this comment.
Nit: should be newline-terminated.
GuillaumeGomez
force-pushed
the
raw-string-error-note
branch
from
b4ee47d
to
74f1489
Compare
estebank
reviewed
Feb 27, 2018
src/test/ui/raw_string.stderr
Outdated
| 14 | | } | ||
| | |__^ | ||
| | | ||
| = note: this raw string should be terminated with `"##` |
There was a problem hiding this comment.
The span should really only point at the first char and have a span label:
error: unterminated raw string
--> $DIR/raw_string.rs:12:13
|
12 | let x = r##"lol"#;
| ^ unterminated raw string
|
= note: this raw string must be terminated with `"##`
|
Other than the nitpick, r=me |
|
r? @estebank |
estebank
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
raw-string-error-note
branch
from
74f1489
to
1c191b2
Compare
|
Updated. |
estebank
approved these changes
Mar 4, 2018
| @@ -269,6 +281,15 @@ impl<'a> StringReader<'a> { | |||
| Self::push_escaped_char_for_msg(&mut m, c); | |||
| self.fatal_span_(from_pos, to_pos, &m[..]) | |||
| } | |||
|
|
|||
| fn struct_span_fatal(&self, | |||
There was a problem hiding this comment.
Is this method necessary after the last change?
There was a problem hiding this comment.
Isn't it being used only in fail_unterminated_raw_string above? The span for the error and the span_label could be made only once (self.mk_span(pos, pos)) and the message and label literal could be the same variable.
|
@bors r+ rollup |
|
📌 Commit 1c191b2 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixes rust-lang#48395. I think this note should be helpful enough to solve the issue.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixes rust-lang#48395. I think this note should be helpful enough to solve the issue.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixes rust-lang#48395. I think this note should be helpful enough to solve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48395.
I think this note should be helpful enough to solve the issue.