Rollup of 14 pull requests #48768

kennytm · 2018-03-06T08:25:43Z

Successful merges: Fix spelling s/casted/cast/ #48403, Suggest type for overflowing bin/hex-literals #48432, Raw string error note #48546, Add functions for reversing the bit pattern in an integer #48573, doc: no need for the reference #48590, Optimize str::repeat #48657, Refactor contrived match. #48727, Remove useless powerpc64 entry from ARCH_TABLE #48732, Remove a couple of isize references from hashmap docs #48753, while let all the things #48754, Remove seemingly unused sugarise-doc-comments Python script. #48761, New Cell docs #48474, Add new warning for CStr::from_ptr #48507, Stabilize FusedIterator #47463
Failed merges:

Also: - apply some rustfmt love - fix output of one example

FusedIterator is a marker trait that promises that the implementing iterator continues to return `None` from `.next()` once it has returned `None` once (and/or `.next_back()`, if implemented). The effects of FusedIterator are already widely available through `.fuse()`, but with stable `FusedIterator`, stable Rust users can implement this trait for their iterators when appropriate.

Also fix a spelling mistake.

This Python script converts documentation comments from the `#[doc = "..."]` attribute to the `///` syntax. It was added six years ago, presumably to help with the transition when `///` was implemented and hasn't really been touched since. I don't think there's much value in keeping it around at this point.

kennytm · 2018-03-06T12:23:08Z

Same error. Some PR is significantly slowing down the jobs.

The timeout happens at stage0-std, meaning changes to rustc only are completely irrelevant.

⭕️ Fix spelling s/casted/cast/ #48403 (Fix spelling s/casted/cast/)
⭕️ Suggest type for overflowing bin/hex-literals #48432 (Suggest type for overflowing bin/hex-literals)
⭕️ Raw string error note #48546 (Raw string error note)
⭕️ Add functions for reversing the bit pattern in an integer #48573 (Add functions for reversing the bit pattern in an integer)
⭕️ doc: no need for the reference #48590 (doc: no need for the reference)
⚠️ Update sccache to its master branch #48647 (Update sccache to its master branch)
⚠️ Optimize str::repeat #48657 (Optimize str::repeat)
⚠️ Update rust-installer #48669 (Update rust-installer)
⭕️ Refactor contrived match. #48727 (Refactor contrived match.)
⭕️ Remove useless powerpc64 entry from ARCH_TABLE #48732 (Remove useless powerpc64 entry from ARCH_TABLE)
⭕️ Remove a couple of isize references from hashmap docs #48753 (Remove a couple of isize references from hashmap docs)
⭕️ while let all the things #48754 (while let all the things)
⭕️ Remove seemingly unused sugarise-doc-comments Python script. #48761 (Remove seemingly unused sugarise-doc-comments Python script.)

(⭕️ = irrelevant, ⚠️ = relevant)

I'm going to remove #48647 because a related bug, #48192, was introduced by sccache.

Optimize str::repeat Improves the performance of `str::repeat` by bulk copying. Here is the benchmarks of `"abcde".repeat(n)`: |`n`|old [ns/iter]|new [ns/iter]|diff [%]| ---|---|---|--- |1|27.205|27.421|+0.794| |2|27.500|27.516|+0.0581| |3|27.923|27.648|-0.985| |4|31.206|30.145|-3.40| |5|35.144|31.861|-9.34| |7|43.131|34.621|-19.7| |10|54.945|36.203|-34.1| |100|428.31|52.895|-87.7|

…h, r=rkruppe Refactor contrived match.

…hton Remove useless powerpc64 entry from ARCH_TABLE Hope, I understood the scope of the fix correctly. closes rust-lang#47737

Remove a couple of `isize` references from hashmap docs Also fix a spelling mistake.

…s, r=rkruppe while let all the things

…crichton Remove seemingly unused sugarise-doc-comments Python script. This Python script converts documentation comments from the `#[doc = "..."]` attribute to the `///` syntax. It was added six years ago, presumably to help with the transition when `///` was implemented and hasn't really been touched since. I don't think there's much value in keeping it around at this point.

…eveklabnik New Cell docs This fixes rust-lang#44061

…abnik Add new warning for CStr::from_ptr Fixes rust-lang#48401.

Stabilize FusedIterator FusedIterator is a marker trait that promises that the implementing iterator continues to return `None` from `.next()` once it has returned `None` once (and/or `.next_back()`, if implemented). The effects of FusedIterator are already widely available through `.fuse()`, but with stable `FusedIterator`, stable Rust users can implement this trait for their iterators when appropriate. Closes rust-lang#35602

kennytm · 2018-03-06T12:55:09Z

@bors r+

Removed #48647, #48669 (the latter is removed due to rebase conflict with Cargo.lock).

bors · 2018-03-06T12:55:10Z

📌 Commit 8e3493d has been approved by kennytm

bors · 2018-03-06T15:01:29Z

⌛ Testing commit 8e3493d with merge 2789b06...

Rollup of 14 pull requests - Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463 - Failed merges:

bors · 2018-03-06T18:03:15Z

💔 Test failed - status-appveyor

alexcrichton · 2018-03-06T18:07:40Z

All dist jobs succeeded, merging manually

pvdrz and others added 30 commits February 22, 2018 13:53

First version

238bb38

add info about sync

f9e049a

remove redundant info

58d1f83

cleaned trailing whitespaces

43de01f

Add new warning for CStr::from_ptr

5344b07

added link to sync containers

ce3ad26

corrected grammar errors

7ded7f7

fixed links

397ce8a

some grammar corrections

9091584

Add bitreverse intrinsic

02e021b

doc: no need for the references

df8dd3f

Also: - apply some rustfmt love - fix output of one example

Suggest type for overflowing bin/hex-literals

e822e62

Implementing requested changes

19c4771

Rewrite error reporting as requested

5c70619

Adapt stderr of UI test to PR rust-lang#48449

f45f760

Fix spelling s/casted/cast/

f7693c0

Optimize str::repeat

08504fb

Remove isize test

15ecf06

core: Update stability attributes for FusedIterator

c7c23fe

Improve getting literal representation

fc33b25

Add comments

683bdc7

Avoid unnecessary calculation

3d58543

Refactor contrived match.

0b0e1b7

Add note for unterminated raw string error

1c191b2

Remove useless powerpc64 entry from ARCH_TABLE, closes rust-lang#47737

16ac85c

Remove a couple of isize references from hashmap docs

88f32d1

Also fix a spelling mistake.

while let all the things

2e7e68b

Add reverse_bits to integer types

24fb4b7

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018

kennytm added 9 commits March 6, 2018 20:52

Rollup merge of rust-lang#48727 - leodasvacas:refactor-contrived-matc…

57cfbea

…h, r=rkruppe Refactor contrived match.

Rollup merge of rust-lang#48732 - debris:remove_powerpc64, r=alexcric…

178b2c4

…hton Remove useless powerpc64 entry from ARCH_TABLE Hope, I understood the scope of the fix correctly. closes rust-lang#47737

Rollup merge of rust-lang#48753 - tbu-:pr_hashmap_isize, r=BurntSushi

7dc3f17

Remove a couple of `isize` references from hashmap docs Also fix a spelling mistake.

Rollup merge of rust-lang#48754 - leodasvacas:while-let-all-the-thing…

b691c52

…s, r=rkruppe while let all the things

Rollup merge of rust-lang#48474 - christianpoveda:new_cell_docs, r=st…

ee94252

…eveklabnik New Cell docs This fixes rust-lang#44061

Rollup merge of rust-lang#48507 - GuillaumeGomez:cstr-note, r=stevekl…

ebc6d6e

…abnik Add new warning for CStr::from_ptr Fixes rust-lang#48401.

kennytm force-pushed the rollup branch from 54d0f41 to 8e3493d Compare March 6, 2018 12:53

kennytm changed the title ~~Rollup of 16 pull requests~~ Rollup of 14 pull requests Mar 6, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2018

kennytm mentioned this pull request Mar 6, 2018

Rollup of 13 pull requests #48776

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018

alexcrichton merged commit 8e3493d into rust-lang:master Mar 6, 2018

bors mentioned this pull request Mar 6, 2018

Move ascii::escape_default to libcore #48735

Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 14 pull requests #48768

Rollup of 14 pull requests #48768

kennytm commented Mar 6, 2018 •

edited

Loading

kennytm commented Mar 6, 2018 •

edited

Loading

kennytm commented Mar 6, 2018

bors commented Mar 6, 2018

bors commented Mar 6, 2018

bors commented Mar 6, 2018

alexcrichton commented Mar 6, 2018

Rollup of 14 pull requests #48768

Rollup of 14 pull requests #48768

Conversation

kennytm commented Mar 6, 2018 • edited Loading

kennytm commented Mar 6, 2018 • edited Loading

kennytm commented Mar 6, 2018

bors commented Mar 6, 2018

bors commented Mar 6, 2018

bors commented Mar 6, 2018

alexcrichton commented Mar 6, 2018

kennytm commented Mar 6, 2018 •

edited

Loading

kennytm commented Mar 6, 2018 •

edited

Loading