Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed test to quiz: fixes issues in #244 #402

Merged
merged 3 commits into from
May 19, 2020
Merged

changed test to quiz: fixes issues in #244 #402

merged 3 commits into from
May 19, 2020

Conversation

sanjaykdragon
Copy link
Contributor

title, refer to
#244

@sanjaykdragon sanjaykdragon mentioned this pull request May 16, 2020
Closed
tonyito
tonyito reviewed May 17, 2020
View reviewed changes
Copy link

@tonyito tonyito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't only renaming the files mess with rustlings watch that is looking for the actual file names to compile?

@sanjaykdragon
Copy link
Contributor Author

Wouldn't only renaming the files mess with rustlings watch that is looking for the actual file names to compile?

you are right, this should fix it

@shadows-withal
Copy link
Member

You would also need to change the reference to the filenames in https://github.com/rust-lang/rustlings/blob/master/README.md#L102.

jrvidal
jrvidal suggested changes May 17, 2020
View reviewed changes
Copy link
Contributor

@jrvidal jrvidal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the title of each exercise? // test1.rs to // quiz1.rs and so forth?

@sanjaykdragon
Copy link
Contributor Author

You would also need to change the reference to the filenames in /README.md@master#L102 .

Didn't notice that, fixed.

Could you change the title of each exercise? // test1.rs to // quiz1.rs and so forth?

Forgot about this, done and also changed up the wording from "test about X" to "quiz about X". let me know if I missed anything

jrvidal
jrvidal approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@jrvidal jrvidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrvidal jrvidal merged commit 010a045 into rust-lang:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyito tonyito tonyito left review comments

@jrvidal jrvidal jrvidal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanjaykdragon @shadows-withal @jrvidal @tonyito