Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: improve wording in interfaces description field #110

Merged

Conversation

phlogistonjohn
Copy link
Collaborator

Thanks to @anoopcs9 for pointing out some potentially confusing wording in the previous patches adding interfaces options include_pattern & exclude_pattern. Change 'system interfaces' to 'network interfaces'.

Thanks to @anoopcs9 for pointing out some potentially confusing wording
in the previous patches adding interfaces options include_pattern &
exclude_pattern. Change 'system interfaces' to 'network interfaces'.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit bbb1801 into samba-in-kubernetes:master Mar 4, 2024
9 checks passed
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn phlogistonjohn deleted the jjm-iface-doc-fix branch March 4, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants