Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in the library #60

Merged
merged 1 commit into from
Mar 20, 2024
Merged

pull in the library #60

merged 1 commit into from
Mar 20, 2024

Conversation

Gregory-Pereira
Copy link
Collaborator

@ppecka
Copy link

ppecka commented Mar 20, 2024

Greg I'm no use here. @bouskaJ Please check the MR

@Gregory-Pereira
Copy link
Collaborator Author

/cc @bouskaJ. That being said, I have tested this and it works, my only question here is from a process standpoint, doesnt seem like a great idea to pull in libraries by hand ...

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot believe it but OK lol

@Gregory-Pereira
Copy link
Collaborator Author

Gregory-Pereira commented Mar 20, 2024

I have a local build of this at: quay.io/grpereir/segment-backup-job@sha256:d6447bc916a9ccb05f20b87bd66fd622f1c385c53c2df246eb910d69f529a831 for amd64 architecture. Will be testing with that for the meantime

@Gregory-Pereira Gregory-Pereira merged commit 6a4f05f into main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants