resolves #516 adds support for private rekor for gitsign attest #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
requested changes
Jun 2, 2024
wlynch
requested changes
Jun 4, 2024
|
@wlynch these have been addressed. thank you |
wlynch
approved these changes
Jun 6, 2024
wlynch
approved these changes
Jun 6, 2024
cpanato
approved these changes
Jun 6, 2024
|
@aalsabag can you rebase? to trigger the dco |
|
context: DCO broke the other day and might need a new commit to retrigger the flow - dcoapp/app#211 |
…tsign attest Signed-off-by: Ahmed Alsabag <ahmed.alsabag@gmail.com>
Signed-off-by: Ahmed Alsabag <ahmed.alsabag@gmail.com>
Signed-off-by: Ahmed Alsabag <ahmed.alsabag@gmail.com>
Signed-off-by: Ahmed Alsabag <ahmed.alsabag@gmail.com>
cpanato
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516
Summary
Gitsign did not support private rekor instances for the gitsign attest command. This adds that feature
Release Note
Fixes gitsign attest's inability to use a private rekor instance
Documentation
NA