Always send updated ack number in ack_reply().
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `ack_reply()` was sending the ack number present in `remote_last_ack`, which is only updated by `dispatch`. This means the ack replies could contain a wrong, old ack number. Most of the time this simply caused wasting an extra roundtrip until the socket state settles down, but in extreme cases it could lead to an infinite loop of packets, such as in smoltcp-rs#338 Fixes smoltcp-rs#338
whitequark
approved these changes
Jun 11, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ack_reply()was sending the ack number present inremote_last_ack,which is only updated by
dispatch. This means the ack replies could containa wrong, old ack number.
Most of the time this simply caused wasting an extra roundtrip until the socket state
settles down, but in extreme cases it could lead to an infinite loop of packets, such
as in #338
Fixes #338