Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always send updated ack number in ack_reply(). #353

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Always send updated ack number in ack_reply(). #353

merged 1 commit into from
Jun 11, 2020

Commits on Jun 11, 2020

  1. Always send updated ack number in ack_reply(). 

    Previously, `ack_reply()` was sending the ack number present in `remote_last_ack`,
which is only updated by `dispatch`. This means the ack replies could contain
a wrong, old ack number.

Most of the time this simply caused wasting an extra roundtrip until the socket state
settles down, but in extreme cases it could lead to an infinite loop of packets, such
as in smoltcp-rs#338

Fixes smoltcp-rs#338
    @Dirbaio
    Dirbaio committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    c6e6c37 View commit details
    Browse the repository at this point in the history