Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for up to 10 circuit outputs. #5795

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jun 13, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor

corelib/src/metaprogramming.cairo line 301 at r1 (raw file):

pub(crate) trait TupleExtendFront<T, E> {
    /// The type of the resulting tuple.
    type Target;

Suggestion:

    /// The type of the resulting tuple.
    type Result;

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


corelib/src/metaprogramming.cairo line 301 at r1 (raw file):

pub(crate) trait TupleExtendFront<T, E> {
    /// The type of the resulting tuple.
    type Target;

Done.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi enabled auto-merge June 16, 2024 06:33
@orizi orizi added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit 39095a2 Jun 16, 2024
85 checks passed
@orizi orizi deleted the pr/orizi/misc/29d3ea61 branch July 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants