Made list of allowed derives explicit. #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orizi
force-pushed
the
pr/orizi/misc/d5816b64
branch
from
7995b3d
to
82162e0
Compare
orizi
force-pushed
the
pr/orizi/misc/29d3ea61
branch
from
0674c85
to
90f01c1
Compare
mkaput
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @maciektr)
orizi
force-pushed
the
pr/orizi/misc/29d3ea61
branch
from
90f01c1
to
d7436d1
Compare
orizi
force-pushed
the
pr/orizi/misc/d5816b64
branch
from
82162e0
to
41bbe72
Compare
orizi
force-pushed
the
pr/orizi/misc/d5816b64
branch
from
41bbe72
to
37d1385
Compare
commit-id:d5816b64
orizi
force-pushed
the
pr/orizi/misc/d5816b64
branch
from
37d1385
to
f60c7a6
Compare
gilbens-starkware
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Reviewed 8 of 10 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:
github-merge-queue bot
pushed a commit
to software-mansion/scarb
that referenced
this pull request
Jun 18, 2024
Derives list is now explicit: starkware-libs/cairo#5804 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is