feat: render all avatars using media server #16193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (285)
|
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
from
7eedf79
to
e7d17ab
Compare
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
11 times, most recently
from
d7a0ec5
to
4cd0a68
Compare
yqrashawn
changed the title
yqrashawn
changed the title
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
from
e047350
to
6394e3d
Compare
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
from
6394e3d
to
60eb947
Compare
yqrashawn
commented
Jun 12, 2023
| @@ -18,124 +13,5 @@ | |||
|
|
|||
| (h/test "Renders even if `:full-name` is passed" | |||
| (h/render | |||
| [user-avatar/user-avatar | |||
There was a problem hiding this comment.
status indicator, initials are renderd by status-go now
yqrashawn
commented
Jun 12, 2023
| @@ -45,11 +45,10 @@ | |||
| :on-press (when on-press on-press) | |||
| :on-long-press (when on-long-press on-long-press)} | |||
| [user-avatar/user-avatar | |||
| {:full-name primary-name | |||
| :profile-picture photo-path | |||
| :status-indicator? true | |||
There was a problem hiding this comment.
:status-indicator? defaults to true
yqrashawn
commented
Jun 12, 2023
src/status_im2/events.cljs
Outdated
| @@ -57,6 +72,7 @@ | |||
| (-> multiaccount | |||
| (dissoc :customizationColor) | |||
| (assoc :customization-color (keyword customizationColor)) | |||
| (assoc :ens-name? (ens/is-valid-eth-name? (:name multiaccount))) | |||
There was a problem hiding this comment.
for multiaccount before login
flexsurfer
reviewed
Jun 12, 2023
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
from
eabbc10
to
8cae06b
Compare
including home view, shell, community, chat
Signed-off-by: yqrashawn <namy.19@gmail.com>
the image file on android is something like file:///storage/emulated/0/Android/data/im.status.ethereum.debug/files/Pictures/dd9acd6f-8906-4641-a800-3aad09fcdfc0.jpg which can't be accessed directly with status-go changed to use the URI directly, no need to go through image server
Signed-off-by: yqrashawn <namy.19@gmail.com>
status-im/status-go@cf2d72b...f2f599f Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
all-user-avatar-from-media-server
branch
from
22916a7
to
30513c7
Compare
|
|
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15271
fixes #15751
fixes #16552
status-go PR status-im/status-go#3513
Note: I cleaned up the this PR's commit history recently so that it can be reviewed commit by commit and will have fewer conflicts in future rebase.
Summary
use status-go media server to render all avatars
{:uri ...}->{:uri ... :fn ...},user-avatarcomponent calls the newly added:fn, passes style related options to that fn and generates the media server URI:setupto get the absolute font file path for initials avatar, which is used by status-go to render the initialsuser-avatarcomponent to support the new patternno-flicker-imagecomponent to cache the image to avoid flicker when re-render on androidmissing avatar for none contact membersame on nightly, separate issueAreas that maybe impacted
affects everywhere has an avatar including onboarding placeholder avatar and avatars in old component/view (profile, contact profile)
status: ready