Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Contact Request flow in Contact Profile #19039

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Implement Contact Request flow in Contact Profile #19039

merged 8 commits into from
Mar 6, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Feb 28, 2024 •
edited
Loading

fixes #18965
aligns with #18998

Summary

This PR attempts to implement the new designs for the Contact Request in Contact Profiles. This PR is dependent on the changes inside PR #18998, which means that contact requests will not support personalised messages until those changes are merged. This PR aligns with the changes inside #18998, but does directly rely on those commits in this branch.

Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • New Contact Profile UI
  • Top-Drawer components
  • Top-Drawer components with Context-Tags

Steps to test

  • Open Status mobile and Status desktop app
  • Enable the new-contact-ui feature flag in the mobile app
  • View a contact profile on mobile
  • Press the contact request button
  • Provide a contact request message and press the "send contact request" button

Before and after screenshots comparison

Before

Screenshot 2024-02-29 at 09 28 58

After

Contact.Request.After.mov

status: ready

@seanstrom seanstrom mentioned this pull request Feb 28, 2024
Merged
@status-im-auto
Copy link
Member

status-im-auto commented Feb 28, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (52)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a90ea68 #1 2024-02-28 15:29:03 ~3 min tests 📄log
✔️ a90ea68 #1 2024-02-28 15:33:16 ~7 min android-e2e 🤖apk 📲
✔️ a90ea68 #1 2024-02-28 15:35:10 ~9 min android 🤖apk 📲
✔️ a90ea68 #1 2024-02-28 15:38:54 ~13 min ios 📱ipa 📲
✔️ 50158d0 #2 2024-02-28 18:40:18 ~7 min tests 📄log
✔️ 50158d0 #2 2024-02-28 18:41:43 ~8 min android 🤖apk 📲
✔️ 50158d0 #2 2024-02-28 18:42:00 ~8 min android-e2e 🤖apk 📲
✔️ 50158d0 #2 2024-02-28 18:44:00 ~10 min ios 📱ipa 📲
✔️ 913963f #3 2024-02-29 10:08:29 ~6 min tests 📄log
✔️ 913963f #3 2024-02-29 10:09:05 ~7 min android-e2e 🤖apk 📲
✔️ 913963f #3 2024-02-29 10:09:12 ~7 min android 🤖apk 📲
✔️ 913963f #3 2024-02-29 10:13:26 ~11 min ios 📱ipa 📲
✔️ 802d9c0 #4 2024-02-29 12:46:30 ~6 min tests 📄log
✔️ 802d9c0 #4 2024-02-29 12:47:50 ~7 min android 🤖apk 📲
✔️ 802d9c0 #4 2024-02-29 12:48:41 ~8 min android-e2e 🤖apk 📲
✔️ 802d9c0 #4 2024-02-29 12:51:30 ~11 min ios 📱ipa 📲
✔️ c043244 #5 2024-02-29 14:32:42 ~6 min tests 📄log
✔️ c043244 #5 2024-02-29 14:34:40 ~7 min android-e2e 🤖apk 📲
✔️ c043244 #5 2024-02-29 14:34:58 ~8 min android 🤖apk 📲
✔️ c043244 #5 2024-02-29 14:38:35 ~11 min ios 📱ipa 📲
✔️ 23f9b9c #6 2024-02-29 14:48:34 ~7 min tests 📄log
✔️ 23f9b9c #6 2024-02-29 14:49:56 ~8 min android-e2e 🤖apk 📲
✔️ 23f9b9c #6 2024-02-29 14:49:56 ~8 min android 🤖apk 📲
✔️ 23f9b9c #6 2024-02-29 14:52:46 ~11 min ios 📱ipa 📲
✔️ fc17a3d #7 2024-02-29 16:27:23 ~7 min tests 📄log
✔️ fc17a3d #7 2024-02-29 16:28:52 ~8 min android-e2e 🤖apk 📲
✔️ fc17a3d #7 2024-02-29 16:28:55 ~8 min android 🤖apk 📲
✔️ fc17a3d #7 2024-02-29 16:31:27 ~11 min ios 📱ipa 📲
✔️ be23df4 #8 2024-03-01 09:22:41 ~7 min tests 📄log
✔️ be23df4 #8 2024-03-01 09:23:59 ~8 min android 🤖apk 📲
✔️ be23df4 #8 2024-03-01 09:24:00 ~8 min android-e2e 🤖apk 📲
✔️ be23df4 #8 2024-03-01 09:27:47 ~12 min ios 📱ipa 📲
✔️ d386e78 #9 2024-03-01 12:08:16 ~7 min tests 📄log
✔️ d386e78 #9 2024-03-01 12:09:34 ~8 min android-e2e 🤖apk 📲
✔️ d386e78 #9 2024-03-01 12:09:54 ~8 min android 🤖apk 📲
✔️ d386e78 #9 2024-03-01 12:11:42 ~10 min ios 📱ipa 📲
❌ db4dca0 #10 2024-03-01 14:09:39 ~1 min tests 📄log
✔️ db4dca0 #10 2024-03-01 14:14:34 ~6 min android 🤖apk 📲
✔️ db4dca0 #10 2024-03-01 14:15:44 ~7 min android-e2e 🤖apk 📲
✔️ db4dca0 #10 2024-03-01 14:18:19 ~10 min ios 📱ipa 📲
✔️ ef88c00 #11 2024-03-01 14:28:34 ~5 min tests 📄log
✔️ ef88c00 #11 2024-03-01 14:30:05 ~7 min android-e2e 🤖apk 📲
✔️ ef88c00 #11 2024-03-01 14:30:11 ~7 min android 🤖apk 📲
✔️ ef88c00 #11 2024-03-01 14:33:02 ~10 min ios 📱ipa 📲
✔️ 46edb23 #12 2024-03-03 12:18:27 ~6 min tests 📄log
✔️ 46edb23 #12 2024-03-03 12:18:45 ~6 min android 🤖apk 📲
✔️ 46edb23 #12 2024-03-03 12:19:34 ~7 min android-e2e 🤖apk 📲
✔️ 46edb23 #12 2024-03-03 12:22:42 ~10 min ios 📱ipa 📲
✔️ 0a24f3d #13 2024-03-05 14:18:35 ~6 min android-e2e 🤖apk 📲
✔️ 0a24f3d #13 2024-03-05 14:18:44 ~6 min android 🤖apk 📲
✔️ 0a24f3d #13 2024-03-05 14:18:55 ~6 min tests 📄log
✔️ 0a24f3d #13 2024-03-05 14:20:46 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 56851b8 #14 2024-03-06 10:41:49 ~7 min android-e2e 🤖apk 📲
✔️ 56851b8 #14 2024-03-06 10:42:39 ~8 min android 🤖apk 📲
✔️ 56851b8 #14 2024-03-06 10:43:14 ~9 min ios 📱ipa 📲
✔️ 56851b8 #15 2024-03-06 11:00:39 ~5 min tests 📄log
✔️ 75dce68 #15 2024-03-06 11:24:07 ~7 min android-e2e 🤖apk 📲
✔️ 75dce68 #15 2024-03-06 11:24:38 ~7 min android 🤖apk 📲
✔️ 75dce68 #15 2024-03-06 11:32:47 ~15 min ios 📱ipa 📲
✔️ 75dce68 #17 2024-03-06 11:55:23 ~3 min tests 📄log

@seanstrom seanstrom changed the title Seanstrom/contact profile contact request Implement Contact Request flow in Contact Profile Feb 28, 2024
@seanstrom seanstrom marked this pull request as ready for review February 29, 2024 10:01
@seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 50158d0 to 913963f Compare February 29, 2024 10:01
seanstrom
seanstrom commented Feb 29, 2024
View reviewed changes
Copy link
Member Author

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Review / Comments

src/status_im/contexts/profile/contact/header/view.cljs Outdated Show resolved Hide resolved
src/quo/components/drawers/drawer_top/view.cljs Show resolved Hide resolved
src/status_im/contexts/profile/contact/contact_request/view.cljs Show resolved Hide resolved
mohsen-ghafouri
mohsen-ghafouri approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM.

@seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 802d9c0 to c043244 Compare February 29, 2024 14:26
@seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 23f9b9c to fc17a3d Compare February 29, 2024 16:19
@status-im-auto
Copy link
Member

17% of end-end tests have passed

Total executed tests: 48
Failed tests: 39
Expected to fail tests: 1
Passed tests: 8

IDs of failed tests: 702809,702782,702733,702784,703194,702859,702732,702813,704613,702957,702840,703495,703086,702948,702894,702745,702783,703297,704615,703496,702936,702855,703202,703391,702786,702839,702947,702838,702844,702843,702807,702731,702808,702730,702845,702775,702958,703629,702841 

IDs of expected to fail tests: 703503

Failed tests (39)

Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find `Button` by `xpath`: `//*[@text="open community"]`
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:68: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Status mobile QA community max' was not requested to join by the url https://status.app/c/G8EAAMR_fz8tsCQ-aR2QrCS5sVAvvzc_N3mAA-En_Zxy4JA3j7Dl1A50Pd4DbooQOMbWf7E1_4wipgDyGe8XZEappDn-Qomf9l_xyXhSYBuSQic8InCEUBSRGR0oixSTh3iw5ZCxzkGSI95Iyu1EBpcIlFOEMPHpKUBIdkkoKBJglMDKko8O8dBvBtIYncOA8mwztwLpx3C0rK_u59PldFuXe4cx#zQ3shwQnEfMtcXpHXF4qJPyCGgw2F18N3nbGzYbzsVHnMq4yK
E    Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
E    Community 'Closed communtiy for e2e' was not requested to join by the url https://status.app/c/G0UAAGS9MeHbo_RoNMnOhOKTCo-fDDbgBCCyNNSN7qrzTqIgLem56TyzYYLf36askV7yGcros8muAdgB#zQ3shVWCcsH94vjf7WrFqBXx5MMAui2EPYMBme8ntACNWWVN3



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 

    critical/test_deep_and_universal_links.py:110: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Status mobile QA community max' was not requested to join by the deep link status.app://c/G8EAAMR_fz8tsCQ-aR2QrCS5sVAvvzc_N3mAA-En_Zxy4JA3j7Dl1A50Pd4DbooQOMbWf7E1_4wipgDyGe8XZEappDn-Qomf9l_xyXhSYBuSQic8InCEUBSRGR0oixSTh3iw5ZCxzkGSI95Iyu1EBpcIlFOEMPHpKUBIdkkoKBJglMDKko8O8dBvBtIYncOA8mwztwLpx3C0rK_u59PldFuXe4cx#zQ3shwQnEfMtcXpHXF4qJPyCGgw2F18N3nbGzYbzsVHnMq4yK
E    Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
E    Community 'Closed communtiy for e2e' was not requested to join by the deep link status.app://c/G0UAAGS9MeHbo_RoNMnOhOKTCo-fDDbgBCCyNNSN7qrzTqIgLem56TyzYYLf36askV7yGcros8muAdgB#zQ3shVWCcsH94vjf7WrFqBXx5MMAui2EPYMBme8ntACNWWVN3



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    6. test_community_edit_delete_message_when_offline, id: 704615 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    7. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    11. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_1_1_chat_push_emoji, id: 702813 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_1_1_chat_edit_message, id: 702855 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    6. test_1_1_chat_send_image_save_and_share, id: 703391 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    7. test_1_1_chat_pin_messages, id: 702731 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    8. test_1_1_chat_message_reaction, id: 702730

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    6. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:544: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_1_1_public_chats.py:544: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496 

    Test setup failed: critical/chats/test_1_1_public_chats.py:544: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: activity_center/test_activity_center.py:271: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:438: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: activity_center/test_activity_center.py:271: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:438: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:822: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:1014: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:822: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:1014: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    3. test_community_mentions_push_notification, id: 702786

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'hey' 

    Test setup failed: critical/chats/test_public_chat_browsing.py:822: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:1014: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:822: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:1014: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:822: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:1014: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: activity_center/test_activity_center.py:394: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:394: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (8)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from fc17a3d to be23df4 Compare March 1, 2024 09:15
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from be23df4 to d386e78 Compare March 1, 2024 12:00
    @status-im-auto
    Copy link
    Member

    88% of end-end tests have passed

    Total executed tests: 48
Failed tests: 5
Expected to fail tests: 1
Passed tests: 42

    IDs of failed tests: 702782,702859,702840,702783,703202 

    IDs of expected to fail tests: 703503

    Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Tap on found: SendMessageButton
    Device 2: Looking for a message by text: Test with link: https://status.im/ here should be nothing unusual. 

    critical/chats/test_1_1_public_chats.py:149: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.chat_element_by_text(url_message).wait_for_element(20)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 2: Click system back button
    Device 2: Looking for a message by text: description 

    critical/chats/test_public_chat_browsing.py:439: in test_community_one_image_send_reply
    self.channel_2.chat_element_by_text(image_description).wait_for_visibility_of_element(10)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 2: Quoting '🈷' message
    Device 2: Find BaseElement by xpath: //*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🈷')] 

    critical/chats/test_public_chat_browsing.py:521: in test_community_emoji_send_copy_paste_reply
    self.channel_2.quote_message(emoji_unicode)
../views/chat_view.py:1072: in quote_message
    self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button)
../views/base_element.py:326: in long_press_until_element_is_shown
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🈷')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:610: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find Button by accessibility id: authors-for-reaction-5
    Device 1: Tap on found: Button 

    critical/chats/test_group_chat.py:211: in test_group_chat_reactions
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect reactions count for user admin after changing the reactions



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (42)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @seanstrom seanstrom mentioned this pull request Mar 1, 2024
    Merged
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from db4dca0 to ef88c00 Compare March 1, 2024 14:22
    @pavloburykh pavloburykh force-pushed the seanstrom/contact-profile-contact-request branch from ef88c00 to 46edb23 Compare March 3, 2024 12:11
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 46edb23 to 0a24f3d Compare March 5, 2024 14:11
    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Mar 5, 2024 •
    edited
    Loading

    @seanstrom thanx for the PR! Does this PR require manual testing? Is anything could be affected in app if feature flag is disabled? Are Top-Drawer components and Top-Drawer components with Context-Tags can be affected in case if feature flag is Disabled? If yes - could you please provide examples of places in app were we should check for regression of this components. Thank you!

    @seanstrom
    Copy link
    Member Author

    Hey @pavloburykh 👋

    The changes to the top-drawer component will be active without the feature flag, and I think we can find examples of it being used by looking for features that use the drawer / bottom-sheet UI. I looked through the code and it seems there's some usages that can be found while requesting to join a community.

    Screen.Recording.2024-03-05.at.16.59.43.mov

    There could be some more examples that are worth double-checking and I'm not sure where all of them are located, but I can help find some other places by looking through the code some more. Lmk if we need some more examples 🙏

    @pavloburykh
    Copy link
    Contributor

    @seanstrom thank you! PR is ready for merge.

    @pavloburykh pavloburykh self-assigned this Mar 5, 2024
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 0a24f3d to 56851b8 Compare March 6, 2024 10:33
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request branch from 56851b8 to 75dce68 Compare March 6, 2024 11:16
    @seanstrom seanstrom merged commit f7498ef into develop Mar 6, 2024
    6 checks passed
    @seanstrom seanstrom deleted the seanstrom/contact-profile-contact-request branch March 6, 2024 12:57
    @mohsen-ghafouri mohsen-ghafouri mentioned this pull request Mar 14, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @yqrashawn yqrashawn yqrashawn approved these changes

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @seanstrom seanstrom

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Feature: New contact request user flow
    6 participants
    @seanstrom @status-im-auto @pavloburykh @yqrashawn @J-Son89 @mohsen-ghafouri