Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status tag for pending contact request to contact profile #19075

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Add status tag for pending contact request to contact profile #19075

merged 2 commits into from
Mar 5, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Mar 1, 2024 •
edited
Loading

fixes #19035

Summary

This PR attempts to add a status-tag for representing a pending contact request on the contact profile. Note, that this PR does not hide the "Send contact request" button. This separation of functionality is to avoid some conflicts with this PR #19039, which will be responsible for hiding the "Send contact request" button after sending a contact request.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • New Contact Profiles

Steps to test

  • Open the Status mobile and desktop app
  • Ensure the profile new-contact-ui feature flag is disabled on mobile
  • Send a contact request from mobile user to desktop user
  • Enable the profile new-contact-ui feature flag on mobile
  • View the Status desktop profile as a contact from the mobile app

Before and after screenshots comparison

Before

Screen.Recording.2024-03-01.at.14.32.32.mov

After

Screen.Recording.2024-03-01.at.14.37.17.mov

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Mar 1, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2b70a02 #1 2024-03-01 14:06:44 ~7 min tests 📄log
✔️ 2b70a02 #1 2024-03-01 14:08:08 ~9 min android-e2e 🤖apk 📲
✔️ 2b70a02 #1 2024-03-01 14:08:14 ~9 min android 🤖apk 📲
✔️ 2b70a02 #1 2024-03-01 14:11:58 ~13 min ios 📱ipa 📲
✔️ 2851a83 #2 2024-03-04 10:42:54 ~6 min android-e2e 🤖apk 📲
✔️ 2851a83 #2 2024-03-04 10:44:26 ~8 min android 🤖apk 📲
✔️ 2851a83 #2 2024-03-04 10:47:41 ~11 min ios 📱ipa 📲
✔️ 7873d33 #3 2024-03-04 13:45:08 ~6 min android-e2e 🤖apk 📲
✔️ 7873d33 #3 2024-03-04 13:45:35 ~7 min tests 📄log
✔️ 7873d33 #3 2024-03-04 13:46:43 ~8 min android 🤖apk 📲
✔️ 7873d33 #3 2024-03-04 13:48:00 ~9 min ios 📱ipa 📲
✔️ 338457f #4 2024-03-04 15:54:59 ~6 min tests 📄log
✔️ 338457f #4 2024-03-04 15:56:00 ~7 min android 🤖apk 📲
✔️ 338457f #4 2024-03-04 15:56:01 ~7 min android-e2e 🤖apk 📲
✔️ 338457f #4 2024-03-04 15:56:32 ~8 min ios 📱ipa 📲
❌ 9f7aca1 #5 2024-03-05 09:16:54 ~7 min tests 📄log
✔️ 9f7aca1 #5 2024-03-05 09:18:04 ~8 min android 🤖apk 📲
✔️ 9f7aca1 #5 2024-03-05 09:18:04 ~8 min android-e2e 🤖apk 📲
✔️ 9f7aca1 #5 2024-03-05 09:20:57 ~11 min ios 📱ipa 📲
✔️ 9f7aca1 #6 2024-03-05 11:04:56 ~1 min tests 📄log
✔️ cc5d226 #7 2024-03-05 11:13:07 ~6 min tests 📄log
✔️ cc5d226 #6 2024-03-05 11:13:26 ~6 min android-e2e 🤖apk 📲
✔️ cc5d226 #6 2024-03-05 11:14:16 ~7 min android 🤖apk 📲
✔️ cc5d226 #6 2024-03-05 11:16:50 ~10 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fa0f025 #7 2024-03-05 12:23:38 ~6 min android-e2e 🤖apk 📲
✔️ fa0f025 #8 2024-03-05 12:24:06 ~7 min tests 📄log
✔️ fa0f025 #7 2024-03-05 12:25:13 ~8 min android 🤖apk 📲
✔️ fa0f025 #7 2024-03-05 12:27:26 ~10 min ios 📱ipa 📲
✔️ 954b1d6 #9 2024-03-05 14:03:23 ~6 min tests 📄log
✔️ 954b1d6 #8 2024-03-05 14:03:45 ~6 min android 🤖apk 📲
✔️ 954b1d6 #8 2024-03-05 14:04:24 ~7 min android-e2e 🤖apk 📲
✔️ 954b1d6 #8 2024-03-05 14:05:23 ~8 min ios 📱ipa 📲

@seanstrom seanstrom marked this pull request as ready for review March 1, 2024 14:40
@seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch from 2b70a02 to 2851a83 Compare March 4, 2024 10:35
@seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch from 2851a83 to 7873d33 Compare March 4, 2024 13:37
@status-im-auto
Copy link
Member

40% of end-end tests have passed

Total executed tests: 48
Failed tests: 28
Expected to fail tests: 1
Passed tests: 19

IDs of failed tests: 702809,702782,702733,703194,702859,702732,702813,702840,703495,703086,702894,702745,703297,704615,702936,702855,703202,703391,702839,702947,702838,702844,702843,702807,702731,702808,702730,702841 

IDs of expected to fail tests: 703503

Failed tests (28)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:980: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_community_edit_delete_message_when_offline, id: 704615 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    7. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    8. test_community_message_send_check_timestamps_sender_username, id: 702838 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    11. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936 

    Test setup failed: activity_center/test_activity_center.py:234: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: activity_center/test_activity_center.py:234: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_group_chat_join_send_text_messages_push, id: 702807 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_1_1_chat_push_emoji, id: 702813 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_1_1_chat_edit_message, id: 702855 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_1_1_chat_send_image_save_and_share, id: 703391 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    7. test_1_1_chat_pin_messages, id: 702731 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    8. test_1_1_chat_message_reaction, id: 702730 

    Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (19)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch from 7873d33 to 338457f Compare March 4, 2024 15:48
    @status-im-auto
    Copy link
    Member

    94% of end-end tests have passed

    Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

    IDs of failed tests: 703202,702731 

    IDs of expected to fail tests: 703503

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find `Text` by `xpath`: `//*[starts-with(@text,'Message 4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
    Device 1: `Text` is `Sent` 

    critical/chats/test_1_1_public_chats.py:222: in test_1_1_chat_pin_messages
    self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered")
../views/chat_view.py:243: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find Button by accessibility id: authors-for-reaction-5
    Device 1: Tap on found: Button 

    critical/chats/test_group_chat.py:211: in test_group_chat_reactions
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect reactions count for member_2 after changing the reactions



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch 2 times, most recently from 9f7aca1 to cc5d226 Compare March 5, 2024 11:06
    @seanstrom
    Copy link
    Member Author

    @status-im/mobile-qa Can you please review the E2E results 🙏

    @pavloburykh
    Copy link
    Contributor

    @seanstrom thanx for the PR. e2e failures are not PR related. Ready for merge.

    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch from cc5d226 to fa0f025 Compare March 5, 2024 12:16
    @seanstrom seanstrom force-pushed the seanstrom/contact-profile-contact-request-pending branch from fa0f025 to 954b1d6 Compare March 5, 2024 13:56
    @seanstrom seanstrom merged commit f788d7b into develop Mar 5, 2024
    6 checks passed
    @seanstrom seanstrom deleted the seanstrom/contact-profile-contact-request-pending branch March 5, 2024 14:07
    @mohsen-ghafouri mohsen-ghafouri mentioned this pull request Mar 14, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @yqrashawn yqrashawn yqrashawn approved these changes

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    Assignees

    @seanstrom seanstrom

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Feature: Indication of Pending Contact Request and hide the request button
    5 participants
    @seanstrom @status-im-auto @pavloburykh @yqrashawn @mohsen-ghafouri