Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: New 4.9 types are not working for Preact #21766

Open
kasperpeulen opened this issue Mar 24, 2023 · 4 comments · May be fixed by #28472
Open

[Bug]: New 4.9 types are not working for Preact #21766

kasperpeulen opened this issue Mar 24, 2023 · 4 comments · May be fixed by #28472
Assignees
@kasperpeulen
Labels
bug help wanted preact sev:S3 typescript

Comments

@kasperpeulen
Copy link
Contributor

Describe the bug

I forget to implement this for Preact, while we actually totally can.

cc @shilman @vanessayuenn to prioritze

To Reproduce

No response

System

No response

Additional context

No response
@kasperpeulen kasperpeulen self-assigned this Mar 24, 2023
kasperpeulen added a commit that referenced this issue Mar 24, 2023
@kasperpeulen
Remove TS 4.9 directory, see #21766
df219dc
@tmueller
Copy link

tmueller commented May 2, 2023

I think only StoryObj will need to have same changes as reacts StoryObj types. Or is there more to do?

@kasperpeulen
Copy link
Contributor Author

@tmueller Correct!

@tmueller
Copy link

tmueller commented May 6, 2023

Let's see, if I can land a PR in the next few days.

@vanessayuenn
Copy link
Contributor

@tmueller that would be fantastic. Thank you for your help!

@NotWoods NotWoods linked a pull request Jul 6, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperpeulen kasperpeulen

Labels
bug help wanted preact sev:S3 typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preact: Pass component instead of props to Meta type NotWoods/storybook
4 participants
@tmueller @shilman @kasperpeulen @vanessayuenn