Preact: Pass component instead of props to Meta type #28472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Updated
code/renderers/preact/package.jsonwith new dependencies for TypeScript features. - Added
code/renderers/preact/src/__test__/Button.stories.tsxfor Button component stories in CSF2 and CSF3 formats. - Introduced
code/renderers/preact/src/__test__/Button.tsxwith a new Button component. - Modified
code/renderers/preact/src/entry-preview.tsto reorder exports and addrenderToCanvas. - Updated
code/renderers/preact/src/render.tsxto simplify rendering and removeStoryHarness.
12 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b5fca27. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
| type AddMocks<TArgs, DefaultArgs> = Simplify<{ | ||
| [T in keyof TArgs]: T extends keyof DefaultArgs | ||
| ? // eslint-disable-next-line @typescript-eslint/ban-types | ||
| DefaultArgs[T] extends (...args: any) => any & { mock: {} } // allow any function with a mock object |
There was a problem hiding this comment.
Can you explain about the mock use case?
There was a problem hiding this comment.
I pretty much just copied React's types here. I assume this is for @storybook/test's fn() result.
kasperpeulen
added
the
ci:daily
|
Could you resolve the merge conflicts @NotWoods? Running CI for this, looks good! |
|
Could you check the build failures? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21766
What I did
The Preact renderer is missing features from the React renderer, such as supporting
Meta<typeof Component>instead ofMeta<ComponentProps>. This PR updates the Preact renderer to be as close as possible to the React renderer source code (sometimes moving lines around) to support all the same TypeScript features. This also includes adding tests, which wasn't present in the package previously.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Run
yarn task checkto validate typing changesDocumentation
TODO: should update docs, porting samples from React
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>