Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why do we use separate webpack configurations? #40

Closed
flosse opened this issue Apr 4, 2016 · 3 comments
Closed

why do we use separate webpack configurations? #40

flosse opened this issue Apr 4, 2016 · 3 comments

Comments

@flosse
Copy link

flosse commented Apr 4, 2016

Most setups already use a webpack configuration and I wonder why do we use a separate one? Of course I could just symlink my config but that doesn't work because the server just uses the module loaders and plugins but ignores everything else. E.g. if I want to use stylus with the nib plugin there is a stylus option within the webpack configuration:

stylus: {
  use: [require('nib')()],
  import: ['~nib/lib/nib/index.styl']
}

Because that option is ignored I can't use the storybook for components that are using nib :(

Can't we go the other way around? Load the main webpack configuration an add/modify it for the server?

@flosse flosse changed the title why do you use separate webpack configurations? why do we use separate webpack configurations? Apr 4, 2016
@arunoda
Copy link
Member

arunoda commented Apr 4, 2016

That's because, Storybook uses it's own server with it's own set of configurations (files) to setup it.
But there's one thing that you can do.

You can import your existing configuration into storybooks file and pick whatever the parts you need.

@timkindberg
Copy link
Contributor

#160 is probably relevant here.

@arunoda
Copy link
Member

arunoda commented May 5, 2016

I think #160 is the best we can have.
Closing this in favour of that.

@arunoda arunoda closed this as completed May 5, 2016
ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 11, 2017
Add the user to the local cache when adding a comment.
thani-sh pushed a commit that referenced this issue May 24, 2017
ndelangen pushed a commit that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants