Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to pass more webpack.config options #43

Closed
wants to merge 3 commits into from

Conversation

BowlingX
Copy link

@BowlingX BowlingX commented Apr 4, 2016

To support loader configurations (mentioned in #40), I made adjustments to support additional configuration properties.

}

config = { ...config, customConfig };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is not what we should do. It's not possible to extend like this since it'll replace our configurations. But I mention is we can import his main webpack config into the webpack config in .storybook directory and get any modules he use.

@arunoda
Copy link
Member

arunoda commented Apr 4, 2016

Currently we only support loaders and plugins. But, if we need something else we can specifically look at it.
This kind of thing will break our app.

BTW: Thanks a lot for the PR.

@arunoda arunoda closed this Apr 4, 2016
@BowlingX
Copy link
Author

BowlingX commented Apr 4, 2016

I removed the plugins and loader configurations from customConfig before, I could also remove the rest that is used by the application (or we assign it the other way around). The Problem is, that some plugins (like postcss-loader) require to be configured in the main configuration.

@arunoda
Copy link
Member

arunoda commented Apr 4, 2016

Could you show me the sample webpack config for postcss-loader. Then we can try to do something.

@BowlingX
Copy link
Author

BowlingX commented Apr 4, 2016

Sure :)

taken from the examples:

var precss       = require('precss');
var autoprefixer = require('autoprefixer');

module.exports = {
    module: {
        loaders: [
            {
                test:   /\.css$/,
                loader: "style-loader!css-loader!postcss-loader"
            }
        ]
    },
    postcss: function () {
        return [precss, autoprefixer];
    }
}

@arunoda arunoda mentioned this pull request Apr 5, 2016
@arunoda
Copy link
Member

arunoda commented Apr 5, 2016

Thanks.
I moved the discussion to here: #46

We can discuss there.

ndelangen pushed a commit that referenced this pull request Apr 5, 2017
fix(ui/components/left_panel): use links for accessibility
ndelangen pushed a commit that referenced this pull request Apr 11, 2017
Add a loading icon for loading comments for the first time.
ndelangen pushed a commit that referenced this pull request Apr 11, 2017
* implement multiple docs navigation

* change docs data strutcure

* styling

* fix routings when responsive view

* Add some real docs.

* Add all basics docs.

* Add management features section.

* Change style.

* Change the header to add Storybook Hub.

* Chaneg nav styles a bit.

* fix some minor issues

* fix storybook failing

* change docs page title according to the categoryh

* Add the comment screenshot.
thani-sh pushed a commit that referenced this pull request May 24, 2017
@shilman shilman added the misc label May 27, 2017
ndelangen pushed a commit that referenced this pull request Feb 23, 2024
Copy link

nx-cloud bot commented Apr 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06f6d68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants