Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use math.div() for divisions #6

Closed
wants to merge 1 commit into from

Conversation

polarbirke
Copy link
Contributor

This fixes #5.

@strarsis
Copy link
Owner

strarsis commented Apr 6, 2022

@polarbirke: Thank you for this contribution!

Would it be possible to add this fix without breaking the compatibility with older implementations like libsass or ruby sass?

@polarbirke
Copy link
Contributor Author

I've seen Bootstrap use a workaround: twbs/rfs#398 if you want to stay backwards-compatible 😄

@strarsis
Copy link
Owner

strarsis commented Apr 6, 2022

@polarbirke: If you could add a divide polyfill to this PR it would be great!

This wouldn't only fix the deprecation warnings and errors (when / division support is removed in future releases of Dart Sass), but also allow for older releases to still use this pow polyfill.

The documentation you add with this PR is very thorough and well-done by the way.

@strarsis
Copy link
Owner

strarsis commented Apr 6, 2022

@polarbirke: Merged #7. (Edit)
Could you also add a PR with your documentation about this, it isn't contained in this PR?
Thanks!

@polarbirke
Copy link
Contributor Author

Ah, I intentionally left out the upgrading guide because now it's an "invisible" fix that doesn't change the interface or requirements for consumers.

What do you think should be documented?

@strarsis
Copy link
Owner

strarsis commented Apr 6, 2022

@polarbirke: You are right, this can be left it out.

@polarbirke
Copy link
Contributor Author

Replaced by #7 (better solution without breaking change).

@polarbirke polarbirke closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO/Note: dart-sass
2 participants