Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New divide() function to prevent Sass deprecation warnings #398

Merged
merged 3 commits into from
Jun 22, 2021
Merged

New divide() function to prevent Sass deprecation warnings #398

merged 3 commits into from
Jun 22, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Jun 18, 2021 •
edited
Loading

Credit to @alpadev for all the divide() function work!

/cc @XhmikosR

@mdo mdo marked this pull request as ready for review June 18, 2021 02:52
@mdo mdo requested a review from MartijnCuppens as a code owner June 18, 2021 02:52
@mdo mdo changed the base branch from main to v9.x June 22, 2021 05:26
@mdo mdo changed the base branch from v9.x to main June 22, 2021 05:26
@XhmikosR XhmikosR merged commit ac9c4d5 into main Jun 22, 2021
@XhmikosR XhmikosR deleted the new-divide branch June 22, 2021 05:28
XhmikosR added a commit that referenced this pull request Jun 22, 2021
@mdo @XhmikosR
New divide() function to prevent Sass deprecation warnings (#398)
60f6102 
* New division function

* Add % to the unit-map

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jun 22, 2021
@mdo @XhmikosR
New divide() function to prevent Sass deprecation warnings (#398)
111ef9f 
* New division function

* Add % to the unit-map

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jun 22, 2021
@mdo @XhmikosR
New divide() function to prevent Sass deprecation warnings (#398)
bf62827 
* New division function

* Add % to the unit-map

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jun 22, 2021
@mdo @XhmikosR
New divide() function to prevent Sass deprecation warnings (#398)
4a0ad3c 
* New division function

* Add % to the unit-map

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Jun 22, 2021
@mdo @XhmikosR
New divide() function to prevent Sass deprecation warnings (#398)
17a9bd5 
* New division function

* Add % to the unit-map

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This was referenced Sep 1, 2021
Merged
Merged
XhmikosR pushed a commit that referenced this pull request Sep 7, 2021
@cdubz
Backport #398 (#421)
9b39d1e 
Use custom `divide` function to prevent Sass deprecation warnings
@AprilArcus AprilArcus mentioned this pull request Mar 2, 2022
Open
@polarbirke polarbirke mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@MartijnCuppens MartijnCuppens Awaiting requested review from MartijnCuppens

Assignees
No one assigned
Labels
Needs backporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdo @XhmikosR