Unregistration of KRaft nodes #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
requested review from
tombentley,
ppatierno,
Frawless,
sknot-rh,
see-quick,
samuel-hawker,
PaulRMellor and
im-konge
Signed-off-by: Jakub Scholz <www@scholzj.com>
PaulRMellor
approved these changes
Aug 12, 2024
Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Jakub Scholz <www@scholzj.com>
Frawless
approved these changes
Aug 12, 2024
showuon
approved these changes
Aug 13, 2024
|
This proposal now seems to have 4 binding and 3 non-binding +1s. If there are no new comments raised until tomorrow CEST EOB, I will close it as approved. |
6 tasks
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Approved with 4 binding and 3 non-binding +1 votes. |
aswinayyolath
pushed a commit
to aswinayyolath/proposals
that referenced
this pull request
Sep 18, 2024
* Unregistration of KRaft nodes Signed-off-by: Jakub Scholz <www@scholzj.com> * Review comments PP Signed-off-by: Jakub Scholz <www@scholzj.com> * Apply suggestions from code review Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Jakub Scholz <www@scholzj.com> * Update index Signed-off-by: Jakub Scholz <www@scholzj.com> --------- Signed-off-by: Jakub Scholz <www@scholzj.com> Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Aswin A <aswin6303@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal describes how we could handle the node unregistration which is part of the existing KRaft limitations.