Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node unregistration in KRaft mode #10442

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 13, 2024

Type of change

  • Enhancement / new feature

Description

This PR implements the KRaft node unregistration at scale-down (node removal) as described in the proposal 81. The unregistration is currently based on our own information carried in the Kafka CR status.

Note: This is currently just a Draft as the proposal is not yet approved.

This should resolve #10296.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@scholzj scholzj added this to the 0.43.0 milestone Aug 13, 2024
@scholzj scholzj requested a review from ppatierno August 13, 2024 19:28
@scholzj
Copy link
Member Author

scholzj commented Aug 13, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 13, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 13, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 14, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj marked this pull request as ready for review August 14, 2024 18:03
@scholzj scholzj requested a review from ppatierno August 14, 2024 18:03
@scholzj
Copy link
Member Author

scholzj commented Aug 14, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 14, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented Aug 15, 2024

/azp run upgrade

@scholzj
Copy link
Member Author

scholzj commented Aug 15, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left just one nit.



Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit f5938a8 into strimzi:main Aug 15, 2024
13 checks passed
@scholzj scholzj deleted the kraft-node-unregistration branch August 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0.43.0
Development

Successfully merging this pull request may close these issues.

Unregister Kafka nodes when scaling down
2 participants