feat: Add ACHv2 support for iOS #861
Conversation
charliecruzan-stripe
requested review from
davidme-stripe
and removed request for
acomley-stripe
android/src/main/java/com/reactnativestripesdk/PaymentLauncherFragment.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativestripesdk/PaymentLauncherFragment.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativestripesdk/PaymentLauncherFragment.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativestripesdk/PaymentMethodCreateParamsFactory.kt
Outdated
Show resolved
Hide resolved
charliecruzan-stripe
force-pushed
the
charliecruzan-achv2-bindings
branch
from
46cb0e5
to
74818d8
Compare
charliecruzan-stripe
changed the title
|
Tests are failing because Webdriver isn't playing nicely with |
ios/PaymentMethodFactory.swift
Outdated
| @@ -47,6 +47,8 @@ class PaymentMethodFactory { | |||
| return try createAfterpayClearpayPaymentMethodParams() | |||
| case STPPaymentMethodType.klarna: | |||
| return try createKlarnaPaymentMethodParams() | |||
| case STPPaymentMethodType.USBankAccount: | |||
| return nil | |||
There was a problem hiding this comment.
for the USBankAccount payment method type, the payment method is created/attached to the intent during collectBankAccountForPayment, so the STPPaymentIntentParams.paymentMethodParams aren't required in this case. Unless we want to allow folks to pass in account number, routing number, etc. directly (after collecting in their own UI, for instance)?
There was a problem hiding this comment.
I believe that is a use case we want to support (it's supported on iOS currently)
There was a problem hiding this comment.
Ah okay, thought that was a security issue and that was why we had a hosted modal for collecting bank account info. I can add that in easily then
There was a problem hiding this comment.
@csabol-stripe added in 9115057
Following this change, it's made me realize we should probably change the confirmPayment (and other similar methods) type to include two separate fields: payment method type and payment method data (right now it's just payment method data, which includes the type). That will make future additions like this one easier. That is out of scope for this PR though, but I will most likely land that change before our V1 release.
This reverts commit d81f48a.
Summary
This exposes 4 methods that React Native devs can use:
collectBankAccountForPayment: opens a modal for customers to provide their US Bank account info and attach it to the specified payment intentcollectBankAccountForSetup: opens a modal for customers to provide their US Bank account info and attach it to the specified setup intentverifyMicrodepositsForPayment: verifies microdeposits for a payment intentverifyMicrodepositsForSetup: verifies microdeposits for a setup intentThese all match methods exposed in stripe.js (in naming and parameters):
Motivation
add support for ACHv2 via bindings on iOS since GA was yesterday,
Testing
Tests are failing because Webdriver isn't playing nicely with macos-latest on GHA, but we need to upgrade to support the newer version of stripe-ios :/ will look into that, but the tests are passing locally on my machine.
Documentation
Select one: