feat: add support for ACHv2 on Android #879

charliecruzan-stripe · 2022-04-07T20:00:36Z

Summary

Added native implementations for

collectBankAccountForPayment
collectBankAccountForSetup
verifyMicrodepositsForPayment
verifyMicrodepositsForSetup

Adds support for USBankAccount type to confirmPayment and confirmSetupIntent

Adds com.stripe:connections:20.0.+ as a package dependency. We could also remove it and make this a user step, i don't have strong feelings either way

This PR also cleans up a lot of our PaymentLauncherFragment.kt code:

added setup intent handling and removed that from StripeSdkModule.kt
wrapped the .confirm and .handleNextAction methods so that it's harder for us to forget to assign the appropriate promise and client secret properties

Until Android officially releases ACHv2, I will re-comment the if (isAndroid) { Javascript checks before landing this PR.

Motivation

Support in iOS was added in #861, this sets us up to be ready for Android's official release

Testing

I tested this manually
I added automated tests

Documentation

Select one:

I have added relevant documentation for my changes.
This PR does not result in any developer-facing changes.

charliecruzan-stripe · 2022-04-08T14:41:20Z

android/build.gradle

@@ -132,7 +132,8 @@ dependencies {
  api 'com.facebook.react:react-native:+'
  implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
  implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.3.1"
-  implementation 'com.stripe:stripe-android:19.3.+'
+  implementation 'com.stripe:stripe-android:20.0.+'
+  implementation 'com.stripe:connections:20.0.+'


Undecided on if this is included by default or we require users to add it

We require our users to add it

We require it for merchants that support ACH, but it's not mandatory for everyone. If you don't want to include the entire library on android for everyone, you can do compileOnly instead, and mention in the docs that users need to add it to their android/build.gradle file. CollectBankAccountLauncher will fail at runtime if the connections code is not available on the classpath.

yep- my question here is if the added size of the connections library is large enough to make users add this to their build.gradle manually. Even small additional steps like that can really cause issues for RN users. And then they're in charge of keeping that version up-to-date with the version of com.stripe:stripe-android we use is stripe-react-native internally. So I lean towards including it in our own library so users don't have to think about it.

charliecruzan-stripe · 2022-04-08T14:42:20Z

android/src/main/java/com/reactnativestripesdk/Mappers.kt

@@ -315,6 +350,28 @@ internal fun mapFromPaymentMethod(paymentMethod: PaymentMethod): WritableMap {

  upi.putString("vpa", paymentMethod.upi?.vpa)

+  // TODO: Remove reflection once USBankAccount is public payment method in stripe-android
+  try {
+    PaymentMethod::class.java.getDeclaredField("usBankAccount").let {


reflection for now for testing, won't need this once feature is public

jameswoo-stripe

Just some concerns around translations

jameswoo-stripe · 2022-04-11T20:20:48Z

android/build.gradle

@@ -132,7 +132,8 @@ dependencies {
  api 'com.facebook.react:react-native:+'
  implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
  implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.3.1"
-  implementation 'com.stripe:stripe-android:19.3.+'
+  implementation 'com.stripe:stripe-android:20.0.+'
+  implementation 'com.stripe:connections:20.0.+'


We require our users to add it

jameswoo-stripe · 2022-04-11T20:21:51Z

android/src/main/java/com/reactnativestripesdk/CollectBankAccountLauncherFragment.kt

+        is CollectBankAccountResult.Completed -> {
+          val intent = result.response.intent
+          if (intent.status === StripeIntent.Status.RequiresPaymentMethod) {
+            promise.resolve(createError(ErrorType.Canceled.toString(), "Bank account collection was canceled."))


Is this customer facing? If it is, should this be translated?

This is developer facing

jameswoo-stripe · 2022-04-12T15:46:15Z

android/src/main/java/com/reactnativestripesdk/PaymentMethodCreateParamsFactory.kt

+  private fun createUSBankAccountPaymentConfirmParams(): ConfirmPaymentIntentParams {
+    params.getString("accountNumber")?.let {
+      if (billingDetailsParams?.name.isNullOrBlank()) {
+        throw PaymentMethodCreateParamsException("When creating a US bank account payment method, you must provide the following billing details: name")


Are these going to be user facing? Or will it be the merchants job to forward this to the user and translate it?

These are developer facing- the exception is caught and then we build a StripeError object which is then resolved via the promise to Javascript. And then yeah, up to the developer to decide what action to take (i.e. show an error message or show some retry option)

carlosmuvi-stripe

Looking good!

carlosmuvi-stripe · 2022-04-12T16:55:34Z

android/build.gradle

@@ -132,7 +132,8 @@ dependencies {
  api 'com.facebook.react:react-native:+'
  implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
  implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.3.1"
-  implementation 'com.stripe:stripe-android:19.3.+'
+  implementation 'com.stripe:stripe-android:20.0.+'
+  implementation 'com.stripe:connections:20.0.+'


We require it for merchants that support ACH, but it's not mandatory for everyone. If you don't want to include the entire library on android for everyone, you can do compileOnly instead, and mention in the docs that users need to add it to their android/build.gradle file. CollectBankAccountLauncher will fail at runtime if the connections code is not available on the classpath.

carlosmuvi-stripe · 2022-04-12T17:02:43Z

android/src/main/java/com/reactnativestripesdk/PaymentMethodCreateParamsFactory.kt

+        clientSecret = clientSecret,
+      )
+    } ?: run {
+      // Payment method is assumed to be already attached through via collectBankAccountForSetup


@jameswoo-stripe I think it's fine, but can we double check we can make this assumption?

Went through the flow with @charliecruzan-stripe, it looks good to me

jameswoo-stripe

lgtm

carlosmuvi-stripe

charliecruzan-stripe added 9 commits April 6, 2022 15:03

upgrade stripe-android

dcb8987

add required mappers

f98c688

add USBankAccount direct payment method creation

09cc702

fix some typings on ios

efc42fe

use boolean instead of string bc better

dad048b

slight improvements to iOS implementation

4301b04

android implementation

0a27298

enable test on android

497c460

changelog and build.gradle

0be3dd0

charliecruzan-stripe changed the title ~~[WIP] feat: add support for ACHv2 on Android~~ feat: add support for ACHv2 on Android Apr 8, 2022

charliecruzan-stripe added 2 commits April 8, 2022 10:40

[skip actions] update changelog

e71c7f5

[skip actions] remove comment

87cf6a0

charliecruzan-stripe commented Apr 8, 2022

View reviewed changes

charliecruzan-stripe marked this pull request as ready for review April 8, 2022 14:41

charliecruzan-stripe requested a review from acomley-stripe as a code owner April 8, 2022 14:41

charliecruzan-stripe removed the request for review from acomley-stripe April 8, 2022 14:41

charliecruzan-stripe commented Apr 8, 2022

View reviewed changes

charliecruzan-stripe requested review from jameswoo-stripe and carlosmuvi-stripe April 8, 2022 16:58

charliecruzan-stripe assigned carlosmuvi-stripe and jameswoo-stripe Apr 8, 2022

charliecruzan-stripe mentioned this pull request Apr 11, 2022

fix: add check to avoid crashes when currentActivity is null #846

Merged

4 tasks

jameswoo-stripe reviewed Apr 12, 2022

View reviewed changes

carlosmuvi-stripe reviewed Apr 12, 2022

View reviewed changes

jameswoo-stripe approved these changes Apr 15, 2022

View reviewed changes

carlosmuvi-stripe approved these changes Apr 15, 2022

View reviewed changes

charliecruzan-stripe added 2 commits April 15, 2022 15:20

[skip actions] add manual bank account details to example screens

7b38e49

[skip actions] remove comments

2b7e0f5

charliecruzan-stripe merged commit 337bb84 into master Apr 15, 2022

charliecruzan-stripe deleted the charliecruzan-achv2-android branch April 15, 2022 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for ACHv2 on Android #879

feat: add support for ACHv2 on Android #879

charliecruzan-stripe commented Apr 7, 2022 •

edited

Loading

charliecruzan-stripe Apr 8, 2022

jameswoo-stripe Apr 11, 2022

carlosmuvi-stripe Apr 12, 2022

charliecruzan-stripe Apr 12, 2022

charliecruzan-stripe Apr 8, 2022

jameswoo-stripe left a comment

jameswoo-stripe Apr 11, 2022

jameswoo-stripe Apr 11, 2022

charliecruzan-stripe Apr 12, 2022

jameswoo-stripe Apr 12, 2022

charliecruzan-stripe Apr 12, 2022

carlosmuvi-stripe left a comment

carlosmuvi-stripe Apr 12, 2022

carlosmuvi-stripe Apr 12, 2022

jameswoo-stripe Apr 15, 2022

jameswoo-stripe left a comment

carlosmuvi-stripe left a comment

feat: add support for ACHv2 on Android #879

feat: add support for ACHv2 on Android #879

Conversation

charliecruzan-stripe commented Apr 7, 2022 • edited Loading

Summary

Motivation

Testing

Documentation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameswoo-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameswoo-stripe left a comment

Choose a reason for hiding this comment

carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

charliecruzan-stripe commented Apr 7, 2022 •

edited

Loading