feat: add support for ACHv2 on Android #879
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package com.reactnativestripesdk | ||
|
|
||
| import android.os.Bundle | ||
| import android.view.LayoutInflater | ||
| import android.view.View | ||
| import android.view.ViewGroup | ||
| import android.widget.FrameLayout | ||
| import androidx.appcompat.app.AppCompatActivity | ||
| import androidx.fragment.app.Fragment | ||
| import com.facebook.react.bridge.Promise | ||
| import com.stripe.android.model.PaymentIntent | ||
| import com.stripe.android.model.SetupIntent | ||
| import com.stripe.android.model.StripeIntent | ||
| import com.stripe.android.payments.bankaccount.CollectBankAccountConfiguration | ||
| import com.stripe.android.payments.bankaccount.CollectBankAccountLauncher | ||
| import com.stripe.android.payments.bankaccount.navigation.CollectBankAccountResult | ||
|
|
||
| class CollectBankAccountLauncherFragment( | ||
| private val activity: AppCompatActivity, | ||
| private val publishableKey: String, | ||
| private val clientSecret: String, | ||
| private val isPaymentIntent: Boolean, | ||
| private val collectParams: CollectBankAccountConfiguration.USBankAccount, | ||
| private val promise: Promise | ||
| ) : Fragment() { | ||
| private lateinit var collectBankAccountLauncher: CollectBankAccountLauncher | ||
|
|
||
| override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, | ||
| savedInstanceState: Bundle?): View { | ||
| collectBankAccountLauncher = createBankAccountLauncher() | ||
|
|
||
| return FrameLayout(requireActivity()).also { | ||
| it.visibility = View.GONE | ||
| } | ||
| } | ||
|
|
||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated( | ||
| view, | ||
| savedInstanceState) | ||
|
|
||
| if (isPaymentIntent) { | ||
| collectBankAccountLauncher.presentWithPaymentIntent( | ||
| publishableKey, | ||
| clientSecret, | ||
| collectParams | ||
| ) | ||
| } else { | ||
| collectBankAccountLauncher.presentWithSetupIntent( | ||
| publishableKey, | ||
| clientSecret, | ||
| collectParams | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| private fun createBankAccountLauncher(): CollectBankAccountLauncher { | ||
| return CollectBankAccountLauncher.create(this) { result -> | ||
| when (result) { | ||
| is CollectBankAccountResult.Completed -> { | ||
| val intent = result.response.intent | ||
| if (intent.status === StripeIntent.Status.RequiresPaymentMethod) { | ||
| promise.resolve(createError(ErrorType.Canceled.toString(), "Bank account collection was canceled.")) | ||
|
There was a problem hiding this comment. Is this customer facing? If it is, should this be translated? There was a problem hiding this comment. This is developer facing |
||
| } else if (intent.status === StripeIntent.Status.RequiresConfirmation) { | ||
| promise.resolve( | ||
| if (isPaymentIntent) | ||
| createResult("paymentIntent", mapFromPaymentIntentResult(intent as PaymentIntent)) | ||
| else | ||
| createResult("setupIntent", mapFromSetupIntentResult(intent as SetupIntent)) | ||
| ) | ||
| } | ||
| } | ||
| is CollectBankAccountResult.Cancelled -> { | ||
| promise.resolve(createError(ErrorType.Canceled.toString(), "Bank account collection was canceled.")) | ||
| } | ||
| is CollectBankAccountResult.Failed -> { | ||
| promise.resolve(createError(ErrorType.Failed.toString(), result.error)) | ||
| } | ||
| } | ||
| activity.supportFragmentManager.beginTransaction().remove(this).commit() | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undecided on if this is included by default or we require users to add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require our users to add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require it for merchants that support ACH, but it's not mandatory for everyone. If you don't want to include the entire library on android for everyone, you can do
compileOnlyinstead, and mention in the docs that users need to add it to theirandroid/build.gradlefile.CollectBankAccountLauncherwill fail at runtime if the connections code is not available on the classpath.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep- my question here is if the added size of the connections library is large enough to make users add this to their build.gradle manually. Even small additional steps like that can really cause issues for RN users. And then they're in charge of keeping that version up-to-date with the version of
com.stripe:stripe-androidwe use is stripe-react-native internally. So I lean towards including it in our own library so users don't have to think about it.