-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated install instructions for new TF and Bazel versions #343
Updated install instructions for new TF and Bazel versions #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Would you also mind updating the install lines in the Tutorial notebooks ? We shouldnt merge this in until we actually cut a release that incorporates the 2.3.0 upgrade Into the non-nightly/master versions (Otherwise our docs would update prematurely). It will be good to have ready for when we do.
FWIW, this worked for me, thank you, @zaqqwerty, I was running into all sorts of issues with the combination of tools that are in the current version of docs. |
If we are going to gear up for a 0.4 release in a week or two, would you mind updating this PR to check for any remaining old references ? Another note is we may want to update the research branch. |
@MichaelBroughton added #395 so we can update the research branch once this is in. Should the workspace file be updated here too? (currently refers to TF 2.2.0) |
Oops, we just fixed the workspace file, could we also update this to 2.3.1 now in anticipation of our cutting a 0.4 soon ? |
Updated to 2.3.1 |
Looking like we are almost ready to pull the trigger on 0.4.0 TFQ. One thing I noticed going through the notebooks was that
I've checked all the tutorials and they seem to function on the latest |
Addressing the Cirq deprecations in #403 |
Add CI check for Python formatting.
Recently did a fresh source build after the update to TF 2.3.0 and Bazel 3.1.0, used what I learned to update the install instructions