Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated install instructions for new TF and Bazel versions #343

Merged

Conversation

zaqqwerty
Copy link
Contributor

Recently did a fresh source build after the update to TF 2.3.0 and Bazel 3.1.0, used what I learned to update the install instructions

Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Would you also mind updating the install lines in the Tutorial notebooks ? We shouldnt merge this in until we actually cut a release that incorporates the 2.3.0 upgrade Into the non-nightly/master versions (Otherwise our docs would update prematurely). It will be good to have ready for when we do.

@balopat
Copy link
Contributor

balopat commented Aug 25, 2020

FWIW, this worked for me, thank you, @zaqqwerty, I was running into all sorts of issues with the combination of tools that are in the current version of docs.

@MichaelBroughton
Copy link
Collaborator

MichaelBroughton commented Sep 17, 2020

If we are going to gear up for a 0.4 release in a week or two, would you mind updating this PR to check for any remaining old references ?

Another note is we may want to update the research branch.

ghost
ghost previously approved these changes Sep 17, 2020
@zaqqwerty
Copy link
Contributor Author

zaqqwerty commented Sep 21, 2020

@MichaelBroughton added #395 so we can update the research branch once this is in. Should the workspace file be updated here too? (currently refers to TF 2.2.0)

@MichaelBroughton
Copy link
Collaborator

Oops, we just fixed the workspace file, could we also update this to 2.3.1 now in anticipation of our cutting a 0.4 soon ?

@zaqqwerty
Copy link
Contributor Author

Updated to 2.3.1

@MichaelBroughton
Copy link
Collaborator

Looking like we are almost ready to pull the trigger on 0.4.0 TFQ. One thing I noticed going through the notebooks was that

  1. PauliString.expectation_from_wavefunction has been deprecated in favor of PauliString.expectation_from_state_vector and TrialResult.final_state has been deprecated in favor of TrialResult.final_state_vector. The calculate gradients tutorial and the hello many worlds tutorial both raise warnings on this. Would you mind updating this in the PR to move to the new names ?

I've checked all the tutorials and they seem to function on the latest tfq-nightly so I think after we fix these deprecation warnings we can merge this PR and #395 Either Tomorrow or the day after and then cut the release 🎉

@zaqqwerty
Copy link
Contributor Author

Addressing the Cirq deprecations in #403

@MichaelBroughton MichaelBroughton merged commit f9a015a into tensorflow:master Oct 6, 2020
@zaqqwerty zaqqwerty deleted the update_install_instructions_2p3p0 branch October 6, 2020 19:14
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants