Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research update 2p3p0 #395

Closed
wants to merge 14 commits into from

Conversation

zaqqwerty
Copy link
Contributor

Updated tf to 2.3.0 in research branch. Will wait for #343 to go in so that I can run the notebooks with this update before merging.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MichaelBroughton
Copy link
Collaborator

Can we upgrade to 2.3.1 here ?

Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to 2.3.1 and remove some of the names that have "Copy_***" in them ? After that I think we'll be good to merge this into research.

@@ -3,7 +3,7 @@
"nbformat_minor": 0,
"metadata": {
"colab": {
"name": "TFQ_Example_BinaryClassifier.ipynb",
"name": "Copy of TFQ_Example_BinaryClassifier.ipynb",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we want to change the name here.

@@ -3,7 +3,7 @@
"nbformat_minor": 0,
"metadata": {
"colab": {
"name": "TFQ_Example_DNN_LSTM_Qcontrol_application.ipynb",
"name": "Copy of TFQ_Example_DNN_LSTM_Qcontrol_application.ipynb",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy

@zaqqwerty zaqqwerty mentioned this pull request Oct 8, 2020
@zaqqwerty
Copy link
Contributor Author

Denoised this PR in #408

@zaqqwerty zaqqwerty closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants