Tools: Topology2: Fix cavs-nocodec.conf SSP2 PCM rates #9382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rate_min and rate_max no more work with IPC4 topologies. The
SSP2 PCM host pipeline contains a sample rate converter so it can
support multiple rates. With attempt to play (or capture) with
other than 48 kHz the error is printed and resulting playback has
wrong pitch:
Warning: rate is not accurate (requested = 44100Hz, got = 48000Hz)
please, try the plug plugin
Use of rates with list of all rates in topology fixes the issue.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
plbossart
reviewed
Aug 21, 2024
| } | ||
|
|
||
| Object.PCM.pcm_caps.2 { | ||
| direction "capture" | ||
| name "SSP2 Capture" | ||
| formats 'S16_LE,S24_LE,S32_LE' | ||
| rate_min 8000 | ||
| rate_max 192000 | ||
| rates "8000,11025,16000,22050,32000,44100,48000,64000,88200,96000,176400,192000" |
| @@ -988,16 +988,14 @@ IncludeByKey.PASSTHROUGH { | |||
| direction "playback" | |||
| name "SSP2 Playback" | |||
| formats 'S16_LE,S24_LE,S32_LE' | |||
| rate_min 8000 | |||
| rate_max 192000 | |||
| rates "8000,11025,16000,22050,32000,44100,48000,64000,88200,96000,176400,192000" | |||
There was a problem hiding this comment.
Yep. I'll test it if can be used.
There was a problem hiding this comment.
Seems it can't be used. In tplg build:
[1/142] Generating sof-tgl-nocodec.tplg
saving nhlt as binary in nhlt-sof-tgl-nocodec.bin
ALSA lib pcm.c:366:(split_rate) unsupported stream rate 24000
ALSA lib parser.c:211:(tplg_load_config) failed to parse topology
Unable to load configuration: Invalid argument
| } | ||
|
|
||
| Object.PCM.pcm_caps.2 { | ||
| direction "capture" | ||
| name "SSP2 Capture" | ||
| formats 'S16_LE,S24_LE,S32_LE' | ||
| rate_min 8000 | ||
| rate_max 192000 | ||
| rates "8000,11025,16000,22050,32000,44100,48000,64000,88200,96000,176400,192000" |
There was a problem hiding this comment.
do we support 44.1? Not sure how the clocks would be derived or maybe this assumes an SRC?
There was a problem hiding this comment.
Yes, there's a SRC in host pipeline for SSP2. I'm trying to replicate with this topology an issue with 44.1 kHz volume with HiFi4 and noticed other than 48 kHz no more worked.
lgirdwood
approved these changes
Aug 21, 2024
kv2019i
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate_min and rate_max no more work with IPC4 topologies. The SSP2 PCM host pipeline contains a sample rate converter so it can support multiple rates. With attempt to play (or capture) with other than 48 kHz the error is printed and resulting playback has wrong pitch:
Warning: rate is not accurate (requested = 44100Hz, got = 48000Hz)
please, try the plug plugin
Use of rates with list of all rates in topology fixes the issue.