Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Topology2: Fix cavs-nocodec.conf SSP2 PCM rates #9382

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Tools: Topology2: Fix cavs-nocodec.conf SSP2 PCM rates #9382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tools/topology/topology2/cavs-nocodec.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,16 +988,14 @@ IncludeByKey.PASSTHROUGH {
direction "playback"
name "SSP2 Playback"
formats 'S16_LE,S24_LE,S32_LE'
rate_min 8000
rate_max 192000
rates "8000,11025,16000,22050,32000,44100,48000,64000,88200,96000,176400,192000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 24000?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I'll test it if can be used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it can't be used. In tplg build:

[1/142] Generating sof-tgl-nocodec.tplg
saving nhlt as binary in nhlt-sof-tgl-nocodec.bin
ALSA lib pcm.c:366:(split_rate) unsupported stream rate 24000
ALSA lib parser.c:211:(tplg_load_config) failed to parse topology
Unable to load configuration: Invalid argument

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think ALSA does not define this 24kHz rate by default but it should be fine if we used a KNOT approach - which may mean a driver change. @ujfalusi @ranj063 FYI.

}

Object.PCM.pcm_caps.2 {
direction "capture"
name "SSP2 Capture"
formats 'S16_LE,S24_LE,S32_LE'
rate_min 8000
rate_max 192000
rates "8000,11025,16000,22050,32000,44100,48000,64000,88200,96000,176400,192000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 24000?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we support 44.1? Not sure how the clocks would be derived or maybe this assumes an SRC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there's a SRC in host pipeline for SSP2. I'm trying to replicate with this topology an issue with 44.1 kHz volume with HiFi4 and noticed other than 48 kHz no more worked.

}
}
]
Expand Down