Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed border default for theme_grey() #3414

Merged
merged 8 commits into from
Jul 8, 2019

Conversation

annennenne
Copy link
Contributor

Changed theme_grey() setting for legend key so that it creates no border (NA) rather than drawing a white one. (closes #3180)

NEWS.md Show resolved Hide resolved
@hadley hadley requested a review from paleolimbot July 8, 2019 12:28
@hadley hadley added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jul 8, 2019
@paleolimbot
Copy link
Member

Hi @annennenne! There are two "visual test cases" that need to be updated, as changing the default theme causes visual changes. If you feel up to it, you can do this yourself by running vdiffr:::vdiffrAddin() in RStudio (you will have to make sure all the dependencies are installed, which you can do using remotes::install_deps(dependencies = TRUE)). If you'd like some help, let me know and I can update the visual test cases for you!

@annennenne
Copy link
Contributor Author

@paleolimbot Thanks for letting me know. I cannot get the app opened by the vdiffr:::vdiffrAddin() call to work properly, and so I'm not sure what to do then.

@paleolimbot
Copy link
Member

I've updated them for this PR...if you'd like to know how to do this for the future, find a helper at TDD (I'm not there, or I'd come over and say hi)!

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @annennenne!

@paleolimbot paleolimbot merged commit 79b16da into tidyverse:master Jul 8, 2019
@lock
Copy link

lock bot commented Jan 4, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical space between legend keys changed after switching theme?
3 participants