-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed border default for theme_grey() #3414
Conversation
…eights the default (closes tidyverse#2902)
…der (NA) rather than drawing a white one.
…der (NA) rather than drawing a white one.
Hi @annennenne! There are two "visual test cases" that need to be updated, as changing the default theme causes visual changes. If you feel up to it, you can do this yourself by running |
@paleolimbot Thanks for letting me know. I cannot get the app opened by the |
I've updated them for this PR...if you'd like to know how to do this for the future, find a helper at TDD (I'm not there, or I'd come over and say hi)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @annennenne!
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Changed
theme_grey()
setting for legend key so that it creates no border (NA
) rather than drawing a white one. (closes #3180)