Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed border default for theme_grey() #3414

Merged
merged 8 commits into from
Jul 8, 2019
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* Changed `theme_grey()` setting for legend key so that it creates no
annennenne marked this conversation as resolved.
Show resolved Hide resolved
border (`NA`) rather than drawing a white one. (@annennenne, #3180)

* Added function `ggplot_add.by()` for lists created with `by()` (#2734, @Maschette)

* `ggdep()` was deprecated (@perezp44, #3382).
Expand Down
2 changes: 1 addition & 1 deletion R/theme-defaults.r
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ theme_grey <- function(base_size = 11, base_family = "",
legend.spacing.x = NULL,
legend.spacing.y = NULL,
legend.margin = margin(half_line, half_line, half_line, half_line),
legend.key = element_rect(fill = "grey95", colour = "white"),
legend.key = element_rect(fill = "grey95", colour = NA),
legend.key.size = unit(1.2, "lines"),
legend.key.height = NULL,
legend.key.width = NULL,
Expand Down
4 changes: 2 additions & 2 deletions tests/figs/themes/theme-gray-large.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/figs/themes/theme-gray.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.