Add categories on json list

[danielebarbaro]

Hi @mattstauffer , first implementation of #143 could be like this:

The json is:

{
  "Cache": [
    [
      {
        "container_id": "3aac7ef4477f",
        "names": "TO--memcached--1.6.7",
        "status": "Up 7 hours",
        "ports": "0.0.0.0:11211->11211\\/tcp"
      }
    ]
  ],
  "Database": [
    [
      {
        "container_id": "4dc197902954",
        "names": "TO--mariadb--focal",
        "status": "Up 7 hours",
        "ports": "0.0.0.0:3342->3306\\/tcp"
      }
    ],
    [
      {
        "container_id": "0daed47e14a5",
        "names": "TO--postgresql--13.0",
        "status": "Up 3 days",
        "ports": "0.0.0.0:5647->5432\\/tcp"
      }
    ]
  ],
  "Mail": [
    [
      {
        "container_id": "202e824629b1",
        "names": "TO--mailhog--v1.0.1",
        "status": "Up 7 hours",
        "ports": "0.0.0.0:8025->8025\\/tcp, 0.0.0.0:2341->1025\\/tcp"
      }
    ]
  ]
}

I decided to group container by category as i've done in the principal menu #88 (PR #135) but we can discuss about it.

I think that isn't useful category column in list output.

[danielebarbaro]

Hi @mattstauffer now PR is updated.
All tests pass.

This PR needs #157 .

[danielebarbaro]

🥺

[mattstauffer]

@danielebarbaro Whoops, sorry!

1. I think I'd prefer we use the lowercase version of the categories, but I'd be up to someone telling me the uppercase is better.
2. My natural inclination would be just to add it to each item in the list rather than grouping them this way. @mpociot as the first person who's talked about possibly consuming this data, what do you think?

[danielebarbaro]

hi @mpociot , what you think about this implementation?

I think I'd prefer we use the lowercase version of the categories, but I'd be up to someone telling me the uppercase is better.

oookkeeeei 🧐 🤓

My natural inclination would be just to add it to each item in the list rather than grouping them this way. @mpociot as the first person who's talked about possibly consuming this data, what do you think?

I prefer grouping to "select" only one group a time 💪🏻

[mattstauffer]

@danielebarbaro OK, I'm going to say definitely throw them into the main body of each entry, and give a flat response of entries.

@josecanhelp had a great idea as well: To add the category under a meta key, so it's separated from the rest.

Thanks!

[danielebarbaro]

Cool, if you need any help i can support you .
I noticed your last PR merges and i saw Base Alias && Full Alias , well done @josecanhelp 🥇

[mattstauffer]

@danielebarbaro If you're up to code the change, I'd love it! If you don't have time, please let me know.

[danielebarbaro]

@danielebarbaro If you're up to code the change, I'd love it! If you don't have time, please let me know.

i'm always on the cutting edge 🏄🏼‍♂️. i will rewrite the PR with the new changes

[danielebarbaro]

Hi @mattstauffer , PR updated but i have some doubts to discuss.

• takeout list --json have different output from takeout list is it what we want?

My opinion is to have same output (add category column on list) and with #173 filter base alias, full alias and category fields
Maybe category can be always present 🧐

• Full Alias and Base Alias are lowercase, category isn't.

My opinion is to have same output :) convert category to lowercase and use ucfirst() on menu (takeout enable).

• behind the scenes i use container name to get the right category however, i would like to use base_alias

My opinion is: container name isn't clean to parse, base alias is "more confident" to use

[danielebarbaro]

🙋🏻‍♂️

[mattstauffer]

takeout list --json have different output from takeout list is it what we want?
Yep!

Full Alias and Base Alias are lowercase, category isn't.
I agree, let's strtolower the category

behind the scenes i use container name to get the right category however, i would like to use base_alias
Makes sense!

[mattstauffer]

I think this would more be a method on the Service class named allByCategory or something like that?

[danielebarbaro]

all() now returns:

$result = [
    'beanstalkd' => "Cache",
    'clickhouse' => "Database",
    'dynamodb' => "Cache",
    'elasticsearch' => "Search",
    'eventstoredb' => "Database",
    'expose' => "Tools",
    'influxdb' => "Database",
    'mailhog' => "Mail",
    'mariadb' => "Database",
    'meilisearch' => "Search",
    'memcached' => "Cache",
    'minio' => "Storage",
    'mongo' => "Database",
    'mssql' => "Database",
    'mysql' => "Database",
    'neo4j' => "Database",
    'postgis' => "Database",
    'postgresql' => "Database",
    'redis' => "Cache",
    'sftp' => "Storage",
    'sqs' => "Cache"
];

so the right name (for me) is mapByService()

[mattstauffer]

Sure, but I still think this is more of a list of services than a list of categories, right?

[danielebarbaro]

whoops sorry 🙈 I misunderstood!
Apologies, you're right, it is a method for Service class.

[mattstauffer]

@danielebarbaro Thanks for all your hard work on this!

[mattstauffer]

@danielebarbaro OK, I'm finally getting back into my open source tasks. Taking a look now!

[mattstauffer]

I know this has been sitting open for ages so I'm sorry to make one more request, but could you write tests for these two new methods?

Thanks so much!