-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add categories on json list #149
Open
danielebarbaro
wants to merge
14
commits into
tighten:main
Choose a base branch
from
danielebarbaro:feature/category-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
52ab9b7
Add categories on json list
danielebarbaro 9086963
Merge branch 'main' into feature/category-json
danielebarbaro 56838b1
Merge branch 'main' into feature/category-json
danielebarbaro d38bd92
Merge branch 'main' into feature/category-json
danielebarbaro c4af2e4
Merge branch 'main' into feature/category-json
danielebarbaro ac58c16
Merge branch 'main' into feature/category-json
danielebarbaro b5a85a3
add category on json output
danielebarbaro 01f2967
Merge branch 'main' into feature/category-json
danielebarbaro 62a11c0
Merge branch 'main' into feature/category-json
danielebarbaro 6f4804e
lowercase category on json list command
danielebarbaro 274c72a
Rename get method on category
danielebarbaro 40c6ab3
Change Category::all method in Category::mapByService
danielebarbaro 287333b
Merge branch 'main' into feature/category-json
danielebarbaro f36ffe8
Review and migrate all() from category class to allByCategory in serv…
danielebarbaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has been sitting open for ages so I'm sorry to make one more request, but could you write tests for these two new methods?
Thanks so much!