Atomize Rename operation when encryption is enabled (#224) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xintao <hunterlxt@live.com>
tabokie
approved these changes
Jan 27, 2021
| @@ -24,6 +24,25 @@ namespace rocksdb { | |||
| static const std::string kRocksDbTFileExt = "sst"; | |||
| static const std::string kLevelDbTFileExt = "ldb"; | |||
| static const std::string kRocksDBBlobFileExt = "blob"; | |||
| static const std::string kUnencryptedTempFileNameSuffix = "dbtmp.plain"; | |||
There was a problem hiding this comment.
Suggested change
| static const std::string kUnencryptedTempFileNameSuffix = "dbtmp.plain"; | |
| static const std::string kUnencryptedTempFileNameSuffix = kTempFileNameSuffix + ".plain"; |
and move this nearby kTempFileNameSuffix?
Comment on lines
+438
to
+439
| Status s = target()->LinkFile(src_fname, dst_fname); | ||
| return s; |
There was a problem hiding this comment.
Suggested change
| Status s = target()->LinkFile(src_fname, dst_fname); | |
| return s; | |
| return target()->LinkFile(src_fname, dst_fname); |
|
@tabokie this is a cherry-pick. Let's keep it as is. |
|
@yiwu-arbug Please mention the cherry-picked PR in the description |
Connor1996
approved these changes
Jan 27, 2021
yiwu-arbug
pushed a commit
to tikv/rust-rocksdb
that referenced
this pull request
Jan 27, 2021
Cherry-picking tikv/rocksdb#224 (tikv/rocksdb#225) Signed-off-by: Yi Wu <yiwu@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #224.
#222 used
LinkFileinstead ofRenameFileapi of key manager. ButLinkFileneeds check the dst file information, inRenameFilelogic, we don't care about that. So just skip encryption for current file.Signed-off-by: Xintao hunterlxt@live.com