Atomize RenameFile in KeyManagedEncryptedEnv #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xintao <hunterlxt@live.com>
hunterlxt
force-pushed
the
xt/handle-encryption-logic-correctly
branch
from
b286c61
to
51fdfa9
Compare
|
@tabokie @Connor1996 PTAL |
tabokie
approved these changes
Dec 16, 2020
hicqu
approved these changes
Dec 16, 2020
yiwu-arbug
requested changes
Dec 16, 2020
encryption/encryption.cc
Outdated
| // Ignore error | ||
| key_manager_->RenameFile(dst_fname, src_fname); | ||
| key_manager_->DeleteFile(dst_fname); |
There was a problem hiding this comment.
do me a favor, update the code like this. also update the same logic for ::LinkFile()
Status delete_status __attribute__((__unused__)) = key_manager_->DeleteFile(dst_name);
assert(delete_stauts.ok());
Great suggestion. Let's remove |
|
revert redundant formatter change? |
yiwu-arbug
reviewed
Dec 17, 2020
hunterlxt
force-pushed
the
xt/handle-encryption-logic-correctly
branch
3 times, most recently
from
3da8411
to
6cdcaa9
Compare
yiwu-arbug
reviewed
Dec 17, 2020
yiwu-arbug
reviewed
Dec 17, 2020
Signed-off-by: Xintao <hunterlxt@live.com>
hunterlxt
force-pushed
the
xt/handle-encryption-logic-correctly
branch
from
eb6dd19
to
0da0b57
Compare
yiwu-arbug
pushed a commit
that referenced
this pull request
Jul 9, 2021
* adjust logic in KeyManagedEncryptedEnv::RenameFile to avoid poweroff Signed-off-by: Xintao <hunterlxt@live.com>
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
* adjust logic in KeyManagedEncryptedEnv::RenameFile to avoid poweroff Signed-off-by: Xintao <hunterlxt@live.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
* adjust logic in KeyManagedEncryptedEnv::RenameFile to avoid poweroff Signed-off-by: Xintao <hunterlxt@live.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 25, 2022
* adjust logic in KeyManagedEncryptedEnv::RenameFile to avoid poweroff Signed-off-by: Xintao <hunterlxt@live.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug: tikv/tikv#9115
Summary: we need to update encryption metadata via
encryption::DataKeyManager, which cannot combine with the actual file operation into one atomic operation. InRenameFile, when the src_file has been removed, power is off, then we may lost the file info of src_file next restart.Signed-off-by: Xintao hunterlxt@live.com