Upgrade to facebook 6.29 #277
Assignees
Comments
|
Are you going to pick our commits to 6.29? In what TiKV version are we going to start using 6.29? |
|
@hunterlxt Soon I hope. Both multi-rocksdb and user timestamp require a newer version of RocksDB. |
This was referenced May 10, 2022
|
A list of facebook features that might interact with our old codebase, needs further scrutiny: |
This was referenced May 10, 2022
tabokie
added a commit
that referenced
this issue
May 11, 2022
Ref #277 When the iterator read keys in reverse order, each Prev() function cost O(log n) times. So I add prev pointer for every node in skiplist to improve the Prev() function. Signed-off-by: Little-Wallace liuwei@pingcap.com Implemented new virtual functions: - `InsertWithHintConcurrently` - `FindRandomEntry` Signed-off-by: tabokie <xy.tao@outlook.com>
This was referenced May 11, 2022
|
I found in v6.29 blobdb is introduced( |
|
blobdb has been already introduced before @hunterlxt |
But I don't find any FFI to |
tabokie
added a commit
to tikv/tikv
that referenced
this issue
Jul 12, 2022
Ref tikv/rocksdb#277 Added some configurations, they will be hidden from doc for now. - rocksdb.xxcf.prepopulate-block-cache-mode = "disabled" - rocksdb.xxcf.format-version = 2 - rocksdb.xxcf.checksum = "crc32c" - WriteOptions::memtable_insert_hint_per_batch = false - ReadOptions::auto_prefix_mode = false - ReadOptions::adaptive_readahead = false A few notes: - `test_need_gc::test_without_properties` is removed, because in the new version of RocksDB, some portion of flushed data is replayed to memtable, and breaks the assumption of file layout. I haven't pinpointed the root cause, but I suppose this test case is not that important. - `test_compact_files_in_range` is partially removed, because it raises error: `Invalid argument: Cannot compact file to up level, input file: /000032.sst level 6 > output level 3`. Signed-off-by: tabokie <xy.tao@outlook.com> Co-authored-by: 5kbpers <hustmh@gmail.com>
joccau
pushed a commit
to joccau/tikv
that referenced
this issue
Jul 14, 2022
Ref tikv/rocksdb#277 Added some configurations, they will be hidden from doc for now. - rocksdb.xxcf.prepopulate-block-cache-mode = "disabled" - rocksdb.xxcf.format-version = 2 - rocksdb.xxcf.checksum = "crc32c" - WriteOptions::memtable_insert_hint_per_batch = false - ReadOptions::auto_prefix_mode = false - ReadOptions::adaptive_readahead = false A few notes: - `test_need_gc::test_without_properties` is removed, because in the new version of RocksDB, some portion of flushed data is replayed to memtable, and breaks the assumption of file layout. I haven't pinpointed the root cause, but I suppose this test case is not that important. - `test_compact_files_in_range` is partially removed, because it raises error: `Invalid argument: Cannot compact file to up level, input file: /000032.sst level 6 > output level 3`. Signed-off-by: tabokie <xy.tao@outlook.com> Co-authored-by: 5kbpers <hustmh@gmail.com>
|
Why #147 is not picked? |
|
@BusyJay The feature is removed in case you forgot: tikv/titan#249 |
Closed
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this issue
Mar 5, 2024
Ref tikv#277 When the iterator read keys in reverse order, each Prev() function cost O(log n) times. So I add prev pointer for every node in skiplist to improve the Prev() function. Signed-off-by: Little-Wallace liuwei@pingcap.com Implemented new virtual functions: - `InsertWithHintConcurrently` - `FindRandomEntry` Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: v01dstar <yang.zhang@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reason for 6.29:
List of TiKV patches in chronological order:
memtable_write_group#171Bullet-ed items are not cherry-picked, for either one of these reasons:
The text was updated successfully, but these errors were encountered: