Add an option to disable write stall #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Connor1996
changed the title
yiwu-arbug
approved these changes
Jul 29, 2021
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Add two test cases to cover the two configs. |
tabokie
reviewed
Aug 11, 2021
| @@ -829,7 +829,7 @@ WriteStallCondition ColumnFamilyData::RecalculateWriteStallConditions( | |||
| name_.c_str(), vstorage->estimated_compaction_needed_bytes(), | |||
| write_controller->delayed_write_rate()); | |||
| } else { | |||
| assert(write_stall_condition == WriteStallCondition::kNormal); | |||
| assert(write_stall_condition == WriteStallCondition::kNormal || mutable_cf_options.disable_write_stall); | |||
There was a problem hiding this comment.
@Connor1996 Minor: should be else if (write_stall_condition == WriteStallCondition::kNormal) ?
There was a problem hiding this comment.
What's the difference
There was a problem hiding this comment.
Each branch has its own precondition, which is "write_stall_condition is unset" here. For this specific spot, breaking the precondition might not cause any trouble, but it's a mistake nonetheless.
There was a problem hiding this comment.
disable_write_stall is a kind of "write_stall_condition is unset", using else if needs to duplicate the logic in else branch.
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Aug 23, 2021
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
Aug 25, 2021
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
Sep 2, 2021
tabokie
added a commit
that referenced
this pull request
Sep 3, 2021
…#258) * Revert "Add an option to disable write stall (#251) (#252)" This reverts commit 32b29a1. Signed-off-by: tabokie <xy.tao@outlook.com> * use ignore_unknown_options regardless of RocksDB version Signed-off-by: tabokie <xy.tao@outlook.com> * disable only for lower version and fix test Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
v01dstar
pushed a commit
to v01dstar/rocksdb
that referenced
this pull request
Mar 5, 2024
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable-write-stallto disable write stall. It avoids RocksDB from being the write stall state, but still keeps the logic of decreasing/increasing compaction threads unchanged as before.base_background_compactionsto decidemax_compactionswhen decrease/increase compaction threads.