Revert #252 and disable ignore_unknown_options only for lower version #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
This was referenced Sep 2, 2021
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
changed the title
yiwu-arbug
approved these changes
Sep 2, 2021
|
/run-tests |
|
/run-tests |
|
temporarily disabling mac build in CI. |
tabokie
added a commit
to tikv/rust-rocksdb
that referenced
this pull request
Sep 3, 2021
Including following commits: - tikv/titan#221 - tikv/titan#218 - tikv/titan#219 - tikv/rocksdb#258 Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #252, newer version can't be rolled back anymore. Revert it.
Also only disable ignore_unknown_options for lower version, so that newer releases of TiKV with new config items can be rolled back to this version.