disable ignore_unknown_options only for lower version #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Connor1996
reviewed
Aug 31, 2021
It seem unsolvable for older releases, we can only make sure 5.2 can rollback to upcoming minor versions of 5.0 and 5.1, and then rollback to older releases because Options file will be updated without unrecognized items. I'll also revert the disable-write-stall config for 5.0 and 5.1 later. |
|
Shall we ignore unknown options only when current version is no less than the previous version, same as what #258 did? |
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
changed the title
yiwu-arbug
approved these changes
Sep 3, 2021
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
Sep 17, 2021
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
Sep 18, 2021
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
May 12, 2022
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 25, 2022
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 25, 2022
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 25, 2022
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 26, 2022
…)" This reverts commit a06cd61. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
Jun 2, 2022
…)" This reverts commit c92ff87. Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
added a commit
that referenced
this pull request
Jun 6, 2022
* disable ignore_unknown_options only for lower version (#256) Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com> * fix CreateDBStatistics visibility issue Signed-off-by: tabokie <xy.tao@outlook.com> * remove blob index access during compaction Signed-off-by: tabokie <xy.tao@outlook.com> * fix build issues Signed-off-by: tabokie <xy.tao@outlook.com> * restore check but tolerate failure Signed-off-by: tabokie <xy.tao@outlook.com> * panic when calling BlobIndex::DecodeFrom Signed-off-by: tabokie <xy.tao@outlook.com> * Revert "disable ignore_unknown_options only for lower version (#256)" This reverts commit a06cd61. Signed-off-by: tabokie <xy.tao@outlook.com> * Revert "panic when calling BlobIndex::DecodeFrom" This reverts commit 53f6fb0. Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie xy.tao@outlook.com
Only enable force option check when reading options file from lower version.