Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version-check for ingested sst #257

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

Little-Wallace
Copy link

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

RocksDB will assign one log sequence number for all sst files which ingested in once call. If all of this files locates in L0, RocksDB will fail to check because the log sequence of them equal.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you encounter this? Seems we ingest file one by one now.

Mind adding a test?

db/version_builder.cc Outdated Show resolved Hide resolved
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Author

/run-test

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiwu-arbug
Copy link
Collaborator

/run-tests

@Little-Wallace
Copy link
Author

/run-test

@yiwu-arbug
Copy link
Collaborator

/run-tests

@Little-Wallace Little-Wallace merged commit d822f13 into tikv:6.4.tikv Sep 3, 2021
yiwu-arbug pushed a commit to tikv/rust-rocksdb that referenced this pull request Sep 6, 2021
update rocksdb to include tikv/rocksdb#257 for master

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@tabokie tabokie mentioned this pull request May 9, 2022
39 tasks
tabokie pushed a commit to tabokie/rocksdb that referenced this pull request May 12, 2022
* fix check log seqno

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie pushed a commit that referenced this pull request May 12, 2022
* fix check log seqno

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants