forked from facebook/rocksdb
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version-check for ingested sst #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
yiwu-arbug
reviewed
Sep 1, 2021
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
yiwu-arbug
approved these changes
Sep 1, 2021
Connor1996
reviewed
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you encounter this? Seems we ingest file one by one now.
Mind adding a test?
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
/run-test |
Connor1996
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-tests |
/run-test |
/run-tests |
yiwu-arbug
pushed a commit
to tikv/rust-rocksdb
that referenced
this pull request
Sep 6, 2021
update rocksdb to include tikv/rocksdb#257 for master Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 12, 2022
* fix check log seqno Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
that referenced
this pull request
May 12, 2022
* fix check log seqno Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace bupt2013211450@gmail.com
RocksDB will assign one log sequence number for all sst files which ingested in once call. If all of this files locates in L0, RocksDB will fail to check because the log sequence of them equal.