-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to query DB stall status #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind explain why we need this specifically? And can that be fulfilled with a callback instead?
Can we implement this as a DB property? That would avoid adding the new DB method, and I think it would be easier to maintain. |
Signed-off-by: qupeng <qupeng@pingcap.com>
7feb4ab
to
87141da
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
Signed-off-by: qupeng <qupeng@pingcap.com>
This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
compaction_filter: add bottommost_level into context (tikv#160) Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> add range for compaction filter context (tikv#192) * add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> allow no_io for VersionSet::GetTableProperties (tikv#211) * allow no_io for VersionSet::GetTableProperties Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> expose seqno from compaction filter and iterator (tikv#215) This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> allow to query DB stall status (tikv#226) This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com> Fix compatibilty issue with Titan Signed-off-by: v01dstar <yang.zhang@pingcap.com> filter deletion in compaction filter (tikv#344) And delay the buffer initialization of writable file to first actual write. --------- Signed-off-by: tabokie <xy.tao@outlook.com> Adjustments for compaptibilty with 8.10.facebook Signed-off-by: v01dstar <yang.zhang@pingcap.com> Adjust tikv related changes with upstream Signed-off-by: v01dstar <yang.zhang@pingcap.com>
Signed-off-by: qupeng qupeng@pingcap.com
This PR adds a new property
is-write-stalled
to query whether the column family is in write stall or not.Why it's necessary?
In TiKV there is a compaction filter used for GC, in which
DB::write
is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources.