Cherry-pick miscellaneous patches to 6.29.tikv #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `WaitForFlushMemTable` API to public. It is needed for hotfix of tikv/titan#93 Signed-off-by: Yi Wu <yiwu@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
The changes are: - make `StatisticsImpl` as a template - remove internal stats due to facebook#4714 Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
force-pushed
the
pick-misc
branch
3 times, most recently
from
1f85419
to
519a120
Compare
Add WAL write duration metric UCP tikv/tikv#6541 Signed-off-by: Wangweizhen <hawking.rei@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Related to tikv/rust-rocksdb#517 and tikv#182 Adds code used in compiling with [rocksdb~6.4.tikv](https://github.com/tikv/rocksdb/tree/6.4.tikv) along with [rocksdb~6.4.cloud](https://github.com/tikv/rocksdb/tree/6.4.cloud) - Makes public the struct LogReporter so that it can be accessed by [rocksdb~6.4.cloud/cloud/manifest_reader.cc#L114](https://github.com/tikv/rocksdb/blob/6a7c514453e3e3e1c3bb57c18d8e0280089ccdcd/cloud/manifest_reader.cc#L114) Signed-off-by: Devdutt Shenoi <devdutt@outlook.in> Signed-off-by: tabokie <xy.tao@outlook.com>
I want to use format of rocksdb::WriteBatch to encode key-value pairs of TiKV, and I need an more effective method to copy data from Entry to WriteBatch directly so that I could avoid CPU cost of decode. Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
* add range for compaction filter context Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
* allow no_io for VersionSet::GetTableProperties Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
This PR supports to access `seqno` for every key/value pairs in compaction filter or iterator. It's helpful to enhance GC in compaction filter in TiKV. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Introduce `FileSystemInspector` interface and `FileSystemInspectedEnv`. With `FileSystemInspectedEnv`, each file operation must first consult `FileSystemInspector` before reaching actual IO logic. Signed-off-by: tabokie <xy.tao@outlook.com>
Add listener for subcompaction, only called when there are actually multiple subcompactions executed in parallel. Signed-off-by: tabokie <xy.tao@outlook.com>
This PR adds a new property is-write-stalled to query whether the column family is in write stall or not. In TiKV there is a compaction filter used for GC, in which DB::write is called. So if we can query whether the DB instance is stalled or not, we can skip to create more compaction filter instances to save some resources. Signed-off-by: qupeng <qupeng@pingcap.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
* add option to disable write stall Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
* fix check log seqno Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Only enable force option check when reading options file from lower version. Signed-off-by: tabokie <xy.tao@outlook.com>
Original PR: facebook#6716 Signed-off-by: Xintao <hunterlxt@live.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: Xintao <hunterlxt@live.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #277
Cherry-pick the following commits: