-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blocks): impl color picker with signals #7585
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
04a585a
to
b9b757e
Compare
@yfield() | ||
accessor color: string | CustomColor = '#000000'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I will check that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it should return #000000
.
## Features - toeverything/blocksuite#7704 @L-Sun - toeverything/blocksuite#7733 @donteatfriedrice - toeverything/blocksuite#7585 @fundon ## Bugfix - toeverything/blocksuite#7749 @zzj3720 - toeverything/blocksuite#7745 @zzj3720 - toeverything/blocksuite#7737 @fundon - toeverything/blocksuite#7734 @fundon - toeverything/blocksuite#7735 @L-Sun - toeverything/blocksuite#7730 @fourdim - toeverything/blocksuite#7718 @fourdim - toeverything/blocksuite#7723 @Flrande ## Refactor - toeverything/blocksuite#7738 @zzj3720 - toeverything/blocksuite#7731 @fourdim - toeverything/blocksuite#7732 @zzj3720 - toeverything/blocksuite#7724 @doouding - toeverything/blocksuite#7725 @doodlewind ## Misc - toeverything/blocksuite#7748 @doodlewind - toeverything/blocksuite#7721 @fundon - toeverything/blocksuite#7729 @fundon - toeverything/blocksuite#7728 @L-Sun - toeverything/blocksuite#7595 @fundon
Closes: BS-610
Add
Color Picker
for custom colorsSupports
note
:background
frame
:background
shape
:fillColor
strokeColor
color
connector
:stroke
labelStyle.color
text
:color
brush
:color
Features
comporents: add
color picker
for custom colorsedgeless-color-picker-button
edgeless-color-picker
edgeless-color-custom-button
models: add
CustomColor
type for color typecolor: string
=>color: string | CustomColor
utils: extand
ThemeObserver
mode
: current theme, light, dark or normalgetColor
: gets a color without going through computed stylegetRealColor
: gets a real color with going through computed stylecolor fallback rules:
CustomColor
and includeslight
anddark
fields, automatically take effect according to different themesCustomColor
and just includesnormal
field, consistent colors across themescss variable
, e.g.--affine-note-background-blue