Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store): signal based Text length #7728

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Jul 25, 2024

Before

class Text {
// ...
  get length() {
    return this._yText.length;
  }
}

After

class Text {
  private _length$: Signal<number>;
// ...
  get length() {
    return this._length$.value;
  }
}

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 7:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 7:27am

Copy link

graphite-app bot commented Jul 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Jul 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

@L-Sun L-Sun temporarily deployed to Lightweight Test July 25, 2024 09:34 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Lightweight Test July 25, 2024 09:34 — with GitHub Actions Inactive
@L-Sun L-Sun requested a review from Saul-Mirone July 25, 2024 09:34
@L-Sun L-Sun marked this pull request as ready for review July 25, 2024 09:34
@L-Sun L-Sun temporarily deployed to Integration Test July 25, 2024 09:36 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Integration Test July 25, 2024 09:36 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 25, 2024 09:37 — with GitHub Actions Inactive
@Saul-Mirone Saul-Mirone requested a review from Flrande July 26, 2024 00:46
Copy link

graphite-app bot commented Jul 26, 2024

Merge activity

L-Sun added a commit that referenced this pull request Jul 26, 2024
## Before
```ts
class Text {
// ...
  get length() {
    return this._yText.length;
  }
}
```

## After
```ts
class Text {
  private _length$: Signal<number>;
// ...
  get length() {
    return this._length$.value;
  }
}
```
@L-Sun L-Sun force-pushed the 07-25-chore_store_signal_based_text_length branch from f99fa0a to 56faf38 Compare July 26, 2024 07:12
@L-Sun L-Sun temporarily deployed to Lightweight Test July 26, 2024 07:16 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@L-Sun L-Sun temporarily deployed to Playground E2E Test July 26, 2024 07:31 — with GitHub Actions Inactive
@graphite-app graphite-app bot merged commit 377b706 into master Jul 26, 2024
19 checks passed
@graphite-app graphite-app bot deleted the 07-25-chore_store_signal_based_text_length branch July 26, 2024 07:40
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
@graphite-app graphite-app bot temporarily deployed to Playground E2E Test July 26, 2024 07:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants