Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add color picker tests for shapes #7727

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jul 25, 2024

No description provided.

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 0:37am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2024 0:37am

Copy link

graphite-app bot commented Jul 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Jul 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from be1b797 to 89df18f Compare July 25, 2024 08:15
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 08:19 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 08:19 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 08:21 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 08:21 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon force-pushed the 07_24-add-tests-for-color-picker branch from 800fd6f to 4dfbd25 Compare July 25, 2024 09:16
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 89df18f to cffa8b7 Compare July 25, 2024 09:16
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 09:20 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 09:20 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 09:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 29, 2024 22:06 — with GitHub Actions Inactive
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 5c03ada to d91dda1 Compare August 1, 2024 22:16
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from d91dda1 to 7578983 Compare August 1, 2024 22:29
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 7578983 to 2705a16 Compare August 2, 2024 08:05
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 2705a16 to 985b01a Compare August 2, 2024 09:17
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 985b01a to 7fbf965 Compare August 5, 2024 02:25
Copy link

nx-cloud bot commented Aug 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7124229. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 3c76405 to 7124229 Compare September 15, 2024 00:35
Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: 7124229

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
@blocksuite/affine-block-list 5.94 KB (0%)
@blocksuite/affine-block-paragraph 4.5 KB (0%)
@blocksuite/affine-block-surface 82.11 KB (0%)
@blocksuite/affine-components 366.81 KB (0%)
@blocksuite/data-view 209.99 KB (0%)
@blocksuite/affine-model 30.03 KB (0%)
@blocksuite/affine-shared 24.29 KB (+0.03% 🔺)
@blocksuite/blocks 3.22 MB (+0.01% 🔺)
@blocksuite/block-std 105.81 KB (0%)
@blocksuite/global 28.4 KB (0%)
@blocksuite/inline 23.76 KB (0%)
@blocksuite/store 64 KB (0%)
@blocksuite/sync 95.99 KB (0%)
@blocksuite/presets 200.68 KB (0%)

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario (calling editor APIs) should fit better in the integration tests in the presets packages, which could also run much faster.

@fundon
Copy link
Contributor Author

fundon commented Sep 19, 2024

This scenario (calling editor APIs) should fit better in the integration tests in the presets packages, which could also run much faster.

I will refactor it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants