feat(isIP): allow usage of options object

[pixelbucket-dev]

This PR implements steps 1 and 2 of #1874 for isIP and builds upon #2075.

This PR extracts tests for isIP into a separate test file ⇾ test/validators/isIP.test.js (inspired by #1793).

I have also added three more tests to guard against other possible values for version.

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0cace52) compared to base (54d330c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2089   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       587    +1     
=========================================
  Hits          2324      2324           

Impacted Files	Coverage Δ
src/lib/isIP.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[braaar]

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

[pixelbucket-dev]

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

[braaar]

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

[WikiRik]

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

It is possible, but then it would be a PR in my fork and not this repo directly. So we'll have to deal with this workaround for now

[pixelbucket-dev]

I think this should be good to go :).

[WikiRik]

Can you undo the changes to the isAlpha tests?

[pixelbucket-dev]

Can you undo the changes to the isAlpha tests?

Sorry, what exactly do you mean? I cannot see anything related to isAlpha in the diff view.

[WikiRik]

In the big test file you removed too much for this PR causing the codecov check to fail

[pixelbucket-dev]

In the big test file you removed too much for this PR causing the codecov check to fail

Done :).

[pixelbucket-dev]

Can this be re-reviewed?